You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/01 02:39:20 UTC

[GitHub] [dolphinscheduler] EricGao888 commented on issue #11211: [Improvement][all] Improvement checksyle

EricGao888 commented on issue #11211:
URL: https://github.com/apache/dolphinscheduler/issues/11211#issuecomment-1200622333

   > > > The current checkstyle detection is incremental detection, and full detection is not required to avoid many PR code conflicts caused by large-scale modifications.
   > > 
   > > 
   > > Or we can just simply appending a note that `To start server when you execute mvn command, you may need to append - Dcheckstyle.skip` in `developer guide docs`?
   > 
   > That sounds good to me. cc @EricGao888 @zhongjiajie
   
   +1, before we fix all the style errors as planned in https://github.com/apache/dolphinscheduler/issues/10573 , I think instructing developers to use `-Dcheckstyle.skip` is a good idea. Thx.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org