[jira] [Comment Edited] (OFBIZ-7482) Deposit price support

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-7482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585185#comment-16585185 ] 

Jacques Le Roux edited comment on OFBIZ-7482 at 8/19/18 4:01 PM:
-----------------------------------------------------------------

Hi Pierre,

bq. This ' improvement' ticket is missing some additional context for adopters/implementors to easily understand its benefit/impact.
I don't think so, it's straitforward, it allows you to create a deposit adjustement in UI when creating an order

bq. it is unclear whether this is intended for purchase order, sales orders or both.
It's obviously for both since the UI is shared.
To be sure I created  https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=10000
Of course it will dissapear at 3h GMT+1, but that really easy to make again ;)

bq. It is lacking sufficient demo data that show how it visualised in an order.
Demo data are not needed to verify this feature in less than 3 mins

bq. It is also lacking (more importantly) the enhancement of the associated function in InvoiceServices.java to ensure that the captured amounts will show up in accounting transactions.
I did not check, but is it not considered as other adjustements? What would be needed more?

bq. Also, the relation to actual deposit goods (defined in the catalog, and registered in warehousing) is not addressed.
Could you elaborate? If you feel it's needed please open one Jira, thanks




was (Author: jacques.le.roux):
Hi Pierre,

bq. This ' improvement' ticket is missing some additional context for adopters/implementors to easily understand its benefit/impact.
I don't think so, it's straitforward, it allows you to create a deposit adjustement in UI when creating an order

bq. it is unclear whether this is intended for purchase order, sales orders or both.
It's obviously for both since the UI is shared.
To be sure I created  https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=10000
Of course it will dissapear at 3h GMT+1

bq. It is lacking sufficient demo data that show how it visualised in an order.
Demo data are not needed to verify this feature in less than 3 mins

bq. It is also lacking (more importantly) the enhancement of the associated function in InvoiceServices.java to ensure that the captured amounts will show up in accounting transactions.
I did not check, but is it not considered as other adjustements? What would be needed more?

bq. Also, the relation to actual deposit goods (defined in the catalog, and registered in warehousing) is not addressed.
Could you elaborate? If you feel it's needed please open one Jira, thanks



> Deposit price support 
> ----------------------
>
>                 Key: OFBIZ-7482
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7482
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order, product
>    Affects Versions: Trunk
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-7482.patch, OFBIZ-7482.patch
>
>
> Business requirements: 
> In many business industry this is very common pattern that you need to pay some amount as deposit for particular products. Such as when you purchase wine or other bottle products, you need to pay some amount as deposit and whenever you return back that bottle, that deposited amount will be refunded to you.
> Technical Details:
> Create a new ProductPricePurpose as 'DEPOSIT' and for similar products we will create product price record with productPriceTypeId as 'DEFAULT_PRICE' and productPricePurposeId as 'DEPOSIT'. At the time of Order creation simply create order adjustments for such products.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)