[jira] [Commented] (THRIFT-3112) [Java] AsyncMethodCallback should be typed in generated AsyncIface

["John Sirois (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132962#comment-15132962 ] 

John Sirois commented on THRIFT-3112:
-------------------------------------

[~roger.meier] I have begun to dig into the {{make check}} failure here - several causes - but they reveal a good deal of broken-ness in the async client side stack.  If you don't object I'd like to assign the issue to myself and carry this home.

> [Java] AsyncMethodCallback should be typed in generated AsyncIface
> ------------------------------------------------------------------
>
>                 Key: THRIFT-3112
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3112
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Compiler
>    Affects Versions: 0.9.2
>            Reporter: Sergei Egorov
>            Assignee: Roger Meier
>              Labels: easyfix
>
> AsyncMethodCallback is generic, but current Java code generator is not adding type info to it, and instead of:
> {code:java}
> public interface AsyncIface {
>     public void ping(org.apache.thrift.async.AsyncMethodCallback<String> resultHandler) throws org.apache.thrift.TException;
>  }
> {code}
> we have:
> {code:java}
> public interface AsyncIface {
>     public void ping(org.apache.thrift.async.AsyncMethodCallback resultHandler) throws org.apache.thrift.TException;
>  }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)