You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/22 19:47:14 UTC

[GitHub] [arrow] wjones127 commented on a change in pull request #12230: ARROW-15415: [C++] Fixes for Windows Debug build

wjones127 commented on a change in pull request #12230:
URL: https://github.com/apache/arrow/pull/12230#discussion_r790178468



##########
File path: cpp/cmake_modules/BuildUtils.cmake
##########
@@ -370,7 +370,7 @@ function(ADD_ARROW_LIB LIB_NAME)
 
     target_link_libraries(${LIB_NAME}_shared
                           LINK_PUBLIC
-                          "$<BUILD_INTERFACE:${ARG_SHARED_LINK_LIBS}>"
+                          ${ARG_SHARED_LINK_LIBS}

Review comment:
       TODO: This works on my machine, but there's probably a reason `BUILD_INTERFACE` was there. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org