[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1249: HDDS-4017. Acceptance check may run against wrong commit

[GitBox <gi...@apache.org>]

adoroszlai opened a new pull request #1249:
URL: https://github.com/apache/hadoop-ozone/pull/1249


   ## What changes were proposed in this pull request?
   
   Use commit SHA to checkout a specific commit on `push` and `schedule` events.  Keep using name for `pull_request` events (eg. `refs/pull/1234/merge`), because merge commit may not be available by SHA.
   
   Use `github` context instead of environment variables.  Github substitutes these values before running the command, so we can see them in the log.  Comparison:
   
   
   ```
   git clone https://github.com/${GITHUB_REPOSITORY}.git /mnt/ozone
   cd /mnt/ozone
   git fetch origin "${GITHUB_REF}"
   git checkout FETCH_HEAD
   ```
   
   vs.
   
   ```
   git clone https://github.com/adoroszlai/hadoop-ozone.git /mnt/ozone
   cd /mnt/ozone
   git fetch origin "refs/heads/HDDS-4017"
   git checkout FETCH_HEAD
   ```
   
   https://issues.apache.org/jira/browse/HDDS-4017
   
   ## How was this patch tested?
   
   `push` event:
   https://github.com/adoroszlai/hadoop-ozone/runs/903007668#step:4:8
   
   `pull_request` event is being tested here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org