You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Mark Chaimungkalanont (JIRA)" <ji...@codehaus.org> on 2006/03/27 11:13:44 UTC
[jira] Created: (MIDEA-41) Source attachments are maintained when
running idea:idea
Source attachments are maintained when running idea:idea
--------------------------------------------------------
Key: MIDEA-41
URL: http://jira.codehaus.org/browse/MIDEA-41
Project: Maven 2.x Idea Plugin
Type: New Feature
Reporter: Mark Chaimungkalanont
Fix For: 2.0
Attachments: patches.diff
This patch will allow source attachments to not be nuked when running {{idea:idea}}. You'll have to run {{idea:idea}} again first (this will put a "name" attribute on your IDEA deps) and _then_ after that, any source you attach to your JAR should be maintained. Note that If you specify the source lib as per MIDEA-26 or {{downloadSources}} tag, your existing source will not be kept.
This patch *does* add a dependency on {{jaxen}} (for xPath) which seems to in turn depend on whole bunch of crap. Not sure if there is a push to keep deps down for the idea plugin or not. MIght be worth keeping in mind when you're evaluating the patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MIDEA-41) Source attachments are maintained when
running idea:idea
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MIDEA-41?page=comments#action_65029 ]
Brett Porter commented on MIDEA-41:
-----------------------------------
the patch unfortunately didn't work:
1) on windows, urls didn't match due to case changes
2) -DdownloadSources=true no longer added sources that weren't there (it wouldn't change an existing element).
I did this, and simplified it at the same time. Algorithm is now:
1) map out all the urls in the IML
2) loop through artifacts. Never replace an entire <library> element, but modify it
2a) if artifact is in IML, replace classes
2b) if downloading sources, replace existing SOURCES (but only if sources are found remotely)
2c) if downloading javadocs, replace existing JAVADOC (but only if javadocs are found remotely)
3) remove any dependencies in IML that were not processed in the list above.
> Source attachments are maintained when running idea:idea
> --------------------------------------------------------
>
> Key: MIDEA-41
> URL: http://jira.codehaus.org/browse/MIDEA-41
> Project: Maven 2.x Idea Plugin
> Type: New Feature
> Reporter: Mark Chaimungkalanont
> Fix For: 2.0
> Attachments: MIDEA-41.patch, patches.diff
>
>
> This patch will allow source attachments to not be nuked when running {{idea:idea}}. You'll have to run {{idea:idea}} again first (this will put a "name" attribute on your IDEA deps) and _then_ after that, any source you attach to your JAR should be maintained. Note that If you specify the source lib as per MIDEA-26 or {{downloadSources}} tag, your existing source will not be kept.
> This patch *does* add a dependency on {{jaxen}} (for xPath) which seems to in turn depend on whole bunch of crap. Not sure if there is a push to keep deps down for the idea plugin or not. MIght be worth keeping in mind when you're evaluating the patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MIDEA-41) Source attachments are maintained when
running idea:idea
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MIDEA-41?page=all ]
Brett Porter closed MIDEA-41:
-----------------------------
Assign To: Brett Porter
Resolution: Fixed
> Source attachments are maintained when running idea:idea
> --------------------------------------------------------
>
> Key: MIDEA-41
> URL: http://jira.codehaus.org/browse/MIDEA-41
> Project: Maven 2.x Idea Plugin
> Type: New Feature
> Reporter: Mark Chaimungkalanont
> Assignee: Brett Porter
> Fix For: 2.0
> Attachments: MIDEA-41.patch, patches.diff
>
>
> This patch will allow source attachments to not be nuked when running {{idea:idea}}. You'll have to run {{idea:idea}} again first (this will put a "name" attribute on your IDEA deps) and _then_ after that, any source you attach to your JAR should be maintained. Note that If you specify the source lib as per MIDEA-26 or {{downloadSources}} tag, your existing source will not be kept.
> This patch *does* add a dependency on {{jaxen}} (for xPath) which seems to in turn depend on whole bunch of crap. Not sure if there is a push to keep deps down for the idea plugin or not. MIght be worth keeping in mind when you're evaluating the patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MIDEA-41) Source attachments are maintained when
running idea:idea
Posted by "Johann Reyes (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MIDEA-41?page=all ]
Johann Reyes updated MIDEA-41:
------------------------------
Attachment: MIDEA-41.patch
> Source attachments are maintained when running idea:idea
> --------------------------------------------------------
>
> Key: MIDEA-41
> URL: http://jira.codehaus.org/browse/MIDEA-41
> Project: Maven 2.x Idea Plugin
> Type: New Feature
> Reporter: Mark Chaimungkalanont
> Fix For: 2.0
> Attachments: MIDEA-41.patch, patches.diff
>
>
> This patch will allow source attachments to not be nuked when running {{idea:idea}}. You'll have to run {{idea:idea}} again first (this will put a "name" attribute on your IDEA deps) and _then_ after that, any source you attach to your JAR should be maintained. Note that If you specify the source lib as per MIDEA-26 or {{downloadSources}} tag, your existing source will not be kept.
> This patch *does* add a dependency on {{jaxen}} (for xPath) which seems to in turn depend on whole bunch of crap. Not sure if there is a push to keep deps down for the idea plugin or not. MIght be worth keeping in mind when you're evaluating the patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MIDEA-41) Source attachments are maintained when
running idea:idea
Posted by "Johann Reyes (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MIDEA-41?page=comments#action_63128 ]
Johann Reyes commented on MIDEA-41:
-----------------------------------
It has been decided better than just keep the sources untouched, it'll be better if we keep the whole library untouched since the library can have for example javadocs attached that we eould also like to keep intact.
> Source attachments are maintained when running idea:idea
> --------------------------------------------------------
>
> Key: MIDEA-41
> URL: http://jira.codehaus.org/browse/MIDEA-41
> Project: Maven 2.x Idea Plugin
> Type: New Feature
> Reporter: Mark Chaimungkalanont
> Fix For: 2.0
> Attachments: patches.diff
>
>
> This patch will allow source attachments to not be nuked when running {{idea:idea}}. You'll have to run {{idea:idea}} again first (this will put a "name" attribute on your IDEA deps) and _then_ after that, any source you attach to your JAR should be maintained. Note that If you specify the source lib as per MIDEA-26 or {{downloadSources}} tag, your existing source will not be kept.
> This patch *does* add a dependency on {{jaxen}} (for xPath) which seems to in turn depend on whole bunch of crap. Not sure if there is a push to keep deps down for the idea plugin or not. MIght be worth keeping in mind when you're evaluating the patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira