[GitHub] [lucene] jpountz commented on a diff in pull request #12446: Enable rank-unsafe optimizations for MAXSCORE/WAND.

["jpountz (via GitHub)" <gi...@apache.org>]

jpountz commented on code in PR #12446:
URL: https://github.com/apache/lucene/pull/12446#discussion_r1271961619


##########
lucene/core/src/java/org/apache/lucene/search/MaxScoreBulkScorer.java:
##########
@@ -168,7 +171,17 @@ private boolean partitionScorers() {
       if (maxScoreSumFloat >= minCompetitiveScore) {
         break;
       }
+      essentialCost -= allScorers[firstEssentialScorer].cost;
     }
+
+    // See if we can further reduce the set of essential scorers while still being above the target
+    // cost.
+    while (firstEssentialScorer < allScorers.length - 1

Review Comment:
   Sub scorers are sorted by ascending maximum score within a window in this scorer. I could add a tie-break on the cost to make it more stable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org