You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/01/10 15:53:56 UTC
[kudu-CR] [backup] Make the scanRequestTimeout unit clear
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12210
Change subject: [backup] Make the scanRequestTimeout unit clear
......................................................................
[backup] Make the scanRequestTimeout unit clear
Changes the scanRequestTimeout parameter to be
scanRequestTimeoutMs to make sure the time unit is
clear.
Change-Id: Id44832a06ae5fb4762a402faff82012729afb5c4
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupOptions.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
3 files changed, 11 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/12210/1
--
To view, visit http://gerrit.cloudera.org:8080/12210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id44832a06ae5fb4762a402faff82012729afb5c4
Gerrit-Change-Number: 12210
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [backup] Make the scanRequestTimeout unit clear
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12210 )
Change subject: [backup] Make the scanRequestTimeout unit clear
......................................................................
[backup] Make the scanRequestTimeout unit clear
Changes the scanRequestTimeout parameter to be
scanRequestTimeoutMs to make sure the time unit is
clear.
Change-Id: Id44832a06ae5fb4762a402faff82012729afb5c4
Reviewed-on: http://gerrit.cloudera.org:8080/12210
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupOptions.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
3 files changed, 11 insertions(+), 8 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id44832a06ae5fb4762a402faff82012729afb5c4
Gerrit-Change-Number: 12210
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [backup] Make the scanRequestTimeout unit clear
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12210 )
Change subject: [backup] Make the scanRequestTimeout unit clear
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id44832a06ae5fb4762a402faff82012729afb5c4
Gerrit-Change-Number: 12210
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 10 Jan 2019 21:53:35 +0000
Gerrit-HasComments: No