You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/04/19 02:29:17 UTC
[GitHub] [iotdb] MarcosZyk opened a new pull request, #5584: Separate SchemaRegion Memory Implementation
MarcosZyk opened a new pull request, #5584:
URL: https://github.com/apache/iotdb/pull/5584
## Description
### Motivation
It is confusing to mix memory mode and schema file mode in one schemaRegion implementation, and it is hard to maintain schema file mode with out affect memory mode.
The implementation of schema file mode already have a little effect on the performance of memory mode, due to try-finally and the Pin/UnPin and memory control mechanism.
### Modification
Separate SchemaRegionMemoryImpl and SchemaRegionSchemaFileImpl, both implement ISchemaRegion.
Separate MTreeBelowSGMemoryImpl and MTreeBelowSGCachedImpl, both implement IMTreeBelowSG.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #5584: Separate SchemaRegion Memory Implementation
Posted by GitBox <gi...@apache.org>.
qiaojialin merged PR #5584:
URL: https://github.com/apache/iotdb/pull/5584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #5584: Separate SchemaRegion Memory Implementation
Posted by GitBox <gi...@apache.org>.
MarcosZyk commented on code in PR #5584:
URL: https://github.com/apache/iotdb/pull/5584#discussion_r852735791
##########
cluster/src/main/java/org/apache/iotdb/cluster/log/manage/PartitionedSnapshotLogManager.java:
##########
@@ -130,7 +130,7 @@ void collectTimeseriesSchemas(List<Integer> requiredSlots) {
}
Collection<TimeseriesSchema> schemas =
slotTimeseries.computeIfAbsent(slot, s -> new HashSet<>());
- IoTDB.schemaProcessor.collectTimeseriesSchema(sgPath, schemas);
+ // IoTDB.schemaProcessor.collectTimeseriesSchema(sgPath, schemas);
Review Comment:
The whole ```Cluster``` module will be removed after release of new cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SilverNarcissus commented on a diff in pull request #5584: Separate SchemaRegion Memory Implementation
Posted by GitBox <gi...@apache.org>.
SilverNarcissus commented on code in PR #5584:
URL: https://github.com/apache/iotdb/pull/5584#discussion_r852718462
##########
cluster/src/main/java/org/apache/iotdb/cluster/query/LocalQueryExecutor.java:
##########
@@ -485,8 +485,8 @@ private void collectSeries(List<String> prefixPaths, List<IMeasurementSchema> me
.computeIfAbsent(slotPreviousHolderMap.get(slot), s -> new ArrayList<>())
.add(new PartialPath(prefixPath));
} else {
- getCSchemaProcessor()
- .collectMeasurementSchema(new PartialPath(prefixPath), measurementSchemas);
+ // getCSchemaProcessor()
Review Comment:
Remove this comment
##########
cluster/src/test/java/org/apache/iotdb/cluster/server/member/MetaGroupMemberTest.java:
##########
@@ -332,7 +332,8 @@ private PullSchemaResp mockedPullTimeSeriesSchema(PullSchemaRequest request) {
try {
for (String prefixPath : prefixPaths) {
if (!prefixPath.equals(TestUtils.getTestSeries(10, 0))) {
- IoTDB.schemaProcessor.collectMeasurementSchema(new PartialPath(prefixPath), schemas);
+ // IoTDB.schemaProcessor.collectMeasurementSchema(new PartialPath(prefixPath),
Review Comment:
Remove this comment
##########
cluster/src/main/java/org/apache/iotdb/cluster/log/manage/PartitionedSnapshotLogManager.java:
##########
@@ -130,7 +130,7 @@ void collectTimeseriesSchemas(List<Integer> requiredSlots) {
}
Collection<TimeseriesSchema> schemas =
slotTimeseries.computeIfAbsent(slot, s -> new HashSet<>());
- IoTDB.schemaProcessor.collectTimeseriesSchema(sgPath, schemas);
+ // IoTDB.schemaProcessor.collectTimeseriesSchema(sgPath, schemas);
Review Comment:
Remove this comment
##########
cluster/src/main/java/org/apache/iotdb/cluster/metadata/MetaPuller.java:
##########
@@ -149,7 +148,7 @@ public void pullMeasurementSchemas(
}
int preSize = results.size();
for (PartialPath prefixPath : prefixPaths) {
- IoTDB.schemaProcessor.collectMeasurementSchema(prefixPath, results);
+ // IoTDB.schemaProcessor.collectMeasurementSchema(prefixPath, results);
Review Comment:
Remove this comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org