You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/01 18:30:38 UTC

[GitHub] [flink] afedulov commented on pull request #19286: [FLINK-25931] Add projection pushdown support for CsvFormatFactory

afedulov commented on PR #19286:
URL: https://github.com/apache/flink/pull/19286#issuecomment-1143994493

   @AHeise I am not sure that the proposed alternative approach makes things much easier. I personally find the implementation of the projection specification as an array of arrays somewhat confusing and would prefer not to spread this abstraction if possible. I find the code of the `CsvRowDataDeserializationSchema` that just operates on input (read from source) and output (converted/projected) data types easier to understand. That way someone who needs to maintain this class does not need to decipher what exactly ` int[][] projections` means. 
   @godfreyhe please let me know if you also think it is worth pursuing this alternative approach to what is currently implemented in the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org