You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@ofbiz.apache.org by William Perng <wp...@salmonllc.com> on 2008/11/27 00:25:17 UTC
Order is charged but still in approved state
We have several orders; the credit card payments have been captured.
However, because exceptions happen after capture, they are still in approved
state. Is there any way to move them to complete? I tried "quick ship
entire order" button and regular pick then pack process. I always get
payment exception and the orders remain in approved state since the payments
have been captured and our credit card service provider doesn't allow me
capture those payments twice.
Thanks
William
Re: Order is charged but still in approved state
Posted by BJ Freeman <bj...@free-man.net>.
The PaymentGatewayServices should only deal with sending and getting
responses from the lower gateway services and dealing with the order.
patching to get around a bug is not a good practice.
So the first is to fix the exceptions that don't allow this to happen,
like fixing why the status is not changed, due to an exception.
https://issues.apache.org/jira/browse/OFBIZ-2001
if you look at the Artifact Info for processReleaseResult
you will see it set the status.
so if the exception happens then the service does not get called.
William Perng sent the following on 11/28/2008 10:33 AM:
> Hi, BJ :
>
> Thank you for your reply. I am wondering can I change the code in
> capturePaymentsByInvoice method (in PaymentGatewayServices.java) to process
> unapplied paymentgatewayresponse entry before calculating the invoice total
> (line 1004 of PaymentGatewayServices.java ver. 66591) to solve this problem?
> The 2nd change we may need in the same place is check the invoice total,
> call captureOrderPayment service only when the invoice total is larger than
> 0.
>
> I thought by doing this the order can be processed by the regular flow,
> event it is failed in the first time.
>
>
> Thanks
>
> William
>
>
> -----Original Message-----
> From: William Perng [mailto:wperng@salmonllc.com]
> Sent: Friday, November 28, 2008 10:10 AM
> To: user@ofbiz.apache.org
> Subject: RE: Order is charged but still in approved state
>
> Payflow
>
> Thanks
>
> William
>
> -----Original Message-----
> From: Sam Hamilton [mailto:sam.hamilton@virtualvillage.com]
> Sent: Friday, November 28, 2008 2:59 AM
> To: user@ofbiz.apache.org
> Subject: RE: Order is charged but still in approved state
>
> Hi William, just wondering which credit card provider you are using to get
> this error?
>
> Thanks
> Sam
>
> -----Original Message-----
> From: BJ Freeman [mailto:bjfree@free-man.net]
> Sent: 27 November 2008 08:15
> To: user@ofbiz.apache.org
> Subject: Re: Order is charged but still in approved state
>
> might look at
> https://demo.hotwaxmedia.com/webtools/control/ArtifactInfo?type=service&uniq
> ueId=changeOrderStatus
>
>
> BJ Freeman sent the following on 11/26/2008 4:10 PM:
>> first you need to fix the code so no exceptions.
>> there is no UI that will let you change the status manually.
>> the problem with using services is they have secas that trigger that
>> will attempt to capture again.
>> the only way I see is to write you own service or manually change them
>> through the webtools
>>
>>
>>
>> William Perng sent the following on 11/26/2008 3:25 PM:
>>> We have several orders; the credit card payments have been captured.
>>> However, because exceptions happen after capture, they are still in
> approved
>>> state. Is there any way to move them to complete? I tried "quick ship
>>> entire order" button and regular pick then pack process. I always get
>>> payment exception and the orders remain in approved state since the
> payments
>>> have been captured and our credit card service provider doesn't allow me
>>> capture those payments twice.
>>>
>>>
>>>
>>> Thanks
>>>
>>>
>>>
>>> William
>>>
>>>
>>
>
>
>
>
RE: Order is charged but still in approved state
Posted by William Perng <wp...@salmonllc.com>.
Hi, BJ :
Thank you for your reply. I am wondering can I change the code in
capturePaymentsByInvoice method (in PaymentGatewayServices.java) to process
unapplied paymentgatewayresponse entry before calculating the invoice total
(line 1004 of PaymentGatewayServices.java ver. 66591) to solve this problem?
The 2nd change we may need in the same place is check the invoice total,
call captureOrderPayment service only when the invoice total is larger than
0.
I thought by doing this the order can be processed by the regular flow,
event it is failed in the first time.
Thanks
William
-----Original Message-----
From: William Perng [mailto:wperng@salmonllc.com]
Sent: Friday, November 28, 2008 10:10 AM
To: user@ofbiz.apache.org
Subject: RE: Order is charged but still in approved state
Payflow
Thanks
William
-----Original Message-----
From: Sam Hamilton [mailto:sam.hamilton@virtualvillage.com]
Sent: Friday, November 28, 2008 2:59 AM
To: user@ofbiz.apache.org
Subject: RE: Order is charged but still in approved state
Hi William, just wondering which credit card provider you are using to get
this error?
Thanks
Sam
-----Original Message-----
From: BJ Freeman [mailto:bjfree@free-man.net]
Sent: 27 November 2008 08:15
To: user@ofbiz.apache.org
Subject: Re: Order is charged but still in approved state
might look at
https://demo.hotwaxmedia.com/webtools/control/ArtifactInfo?type=service&uniq
ueId=changeOrderStatus
BJ Freeman sent the following on 11/26/2008 4:10 PM:
> first you need to fix the code so no exceptions.
> there is no UI that will let you change the status manually.
> the problem with using services is they have secas that trigger that
> will attempt to capture again.
> the only way I see is to write you own service or manually change them
> through the webtools
>
>
>
> William Perng sent the following on 11/26/2008 3:25 PM:
>> We have several orders; the credit card payments have been captured.
>> However, because exceptions happen after capture, they are still in
approved
>> state. Is there any way to move them to complete? I tried "quick ship
>> entire order" button and regular pick then pack process. I always get
>> payment exception and the orders remain in approved state since the
payments
>> have been captured and our credit card service provider doesn't allow me
>> capture those payments twice.
>>
>>
>>
>> Thanks
>>
>>
>>
>> William
>>
>>
>
>
RE: Order is charged but still in approved state
Posted by William Perng <wp...@salmonllc.com>.
Payflow
Thanks
William
-----Original Message-----
From: Sam Hamilton [mailto:sam.hamilton@virtualvillage.com]
Sent: Friday, November 28, 2008 2:59 AM
To: user@ofbiz.apache.org
Subject: RE: Order is charged but still in approved state
Hi William, just wondering which credit card provider you are using to get
this error?
Thanks
Sam
-----Original Message-----
From: BJ Freeman [mailto:bjfree@free-man.net]
Sent: 27 November 2008 08:15
To: user@ofbiz.apache.org
Subject: Re: Order is charged but still in approved state
might look at
https://demo.hotwaxmedia.com/webtools/control/ArtifactInfo?type=service&uniq
ueId=changeOrderStatus
BJ Freeman sent the following on 11/26/2008 4:10 PM:
> first you need to fix the code so no exceptions.
> there is no UI that will let you change the status manually.
> the problem with using services is they have secas that trigger that
> will attempt to capture again.
> the only way I see is to write you own service or manually change them
> through the webtools
>
>
>
> William Perng sent the following on 11/26/2008 3:25 PM:
>> We have several orders; the credit card payments have been captured.
>> However, because exceptions happen after capture, they are still in
approved
>> state. Is there any way to move them to complete? I tried "quick ship
>> entire order" button and regular pick then pack process. I always get
>> payment exception and the orders remain in approved state since the
payments
>> have been captured and our credit card service provider doesn't allow me
>> capture those payments twice.
>>
>>
>>
>> Thanks
>>
>>
>>
>> William
>>
>>
>
>
RE: Order is charged but still in approved state
Posted by Sam Hamilton <sa...@virtualvillage.com>.
Hi William, just wondering which credit card provider you are using to get this error?
Thanks
Sam
-----Original Message-----
From: BJ Freeman [mailto:bjfree@free-man.net]
Sent: 27 November 2008 08:15
To: user@ofbiz.apache.org
Subject: Re: Order is charged but still in approved state
might look at
https://demo.hotwaxmedia.com/webtools/control/ArtifactInfo?type=service&uniqueId=changeOrderStatus
BJ Freeman sent the following on 11/26/2008 4:10 PM:
> first you need to fix the code so no exceptions.
> there is no UI that will let you change the status manually.
> the problem with using services is they have secas that trigger that
> will attempt to capture again.
> the only way I see is to write you own service or manually change them
> through the webtools
>
>
>
> William Perng sent the following on 11/26/2008 3:25 PM:
>> We have several orders; the credit card payments have been captured.
>> However, because exceptions happen after capture, they are still in approved
>> state. Is there any way to move them to complete? I tried "quick ship
>> entire order" button and regular pick then pack process. I always get
>> payment exception and the orders remain in approved state since the payments
>> have been captured and our credit card service provider doesn't allow me
>> capture those payments twice.
>>
>>
>>
>> Thanks
>>
>>
>>
>> William
>>
>>
>
>
Re: Order is charged but still in approved state
Posted by BJ Freeman <bj...@free-man.net>.
might look at
https://demo.hotwaxmedia.com/webtools/control/ArtifactInfo?type=service&uniqueId=changeOrderStatus
BJ Freeman sent the following on 11/26/2008 4:10 PM:
> first you need to fix the code so no exceptions.
> there is no UI that will let you change the status manually.
> the problem with using services is they have secas that trigger that
> will attempt to capture again.
> the only way I see is to write you own service or manually change them
> through the webtools
>
>
>
> William Perng sent the following on 11/26/2008 3:25 PM:
>> We have several orders; the credit card payments have been captured.
>> However, because exceptions happen after capture, they are still in approved
>> state. Is there any way to move them to complete? I tried "quick ship
>> entire order" button and regular pick then pack process. I always get
>> payment exception and the orders remain in approved state since the payments
>> have been captured and our credit card service provider doesn't allow me
>> capture those payments twice.
>>
>>
>>
>> Thanks
>>
>>
>>
>> William
>>
>>
>
>
Re: Order is charged but still in approved state
Posted by BJ Freeman <bj...@free-man.net>.
first you need to fix the code so no exceptions.
there is no UI that will let you change the status manually.
the problem with using services is they have secas that trigger that
will attempt to capture again.
the only way I see is to write you own service or manually change them
through the webtools
William Perng sent the following on 11/26/2008 3:25 PM:
> We have several orders; the credit card payments have been captured.
> However, because exceptions happen after capture, they are still in approved
> state. Is there any way to move them to complete? I tried "quick ship
> entire order" button and regular pick then pack process. I always get
> payment exception and the orders remain in approved state since the payments
> have been captured and our credit card service provider doesn't allow me
> capture those payments twice.
>
>
>
> Thanks
>
>
>
> William
>
>