[jira] [Commented] (SUREFIRE-2140) Cannot release Surefire on Windows

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SUREFIRE-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17718304#comment-17718304 ] 

ASF GitHub Bot commented on SUREFIRE-2140:
------------------------------------------

michael-o opened a new pull request, #626:
URL: https://github.com/apache/maven-surefire/pull/626

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   




> Cannot release Surefire on Windows
> ----------------------------------
>
>                 Key: SUREFIRE-2140
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-2140
>             Project: Maven Surefire
>          Issue Type: Bug
>    Affects Versions: 3.0.0-M7
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 3.1.0
>
>
> While trying to release Surefire on Windows today Git failed with: fatal: CRLF would be replaced by LF in pom.xml
> It turns out that the {{.gitattributes}} is:
> {noformat}
> # Auto detect text files and perform LF normalization
> * text eol=lf
> *.xml    text diff=xml
> *.java   text diff=java
> *.html   text diff=html
> *.vm     text
> *.fml    text
> *.md     text
> *.css    text
> *.js     text
> *.sql    text
> *.png    binary
> {noformat}
> I don't know why LF is enforced, but most Git clients will perform {{autocrlf}} and Maven Release Plugin will use platform line separator. Therefore, it will have CRLF after transformation and Git fails, thus release fails. I had to perform in Git Bash:
> {noformat}
> git status | grep modified: | cut -c13-  | xargs -I^ dos2unix ^
> {noformat}
> through several stages to continue with the release.
> Expectation: Either Git will be configured to use LS auto or Maven Release Plugin will force LF only.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)