You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by "Richard Liang (JIRA)" <ji...@apache.org> on 2006/02/27 07:06:57 UTC
[jira] Commented: (HARMONY-123) Refactor:
java.nio.charset.CharsetDecoder.decode
[ http://issues.apache.org/jira/browse/HARMONY-123?page=comments#action_12367898 ]
Richard Liang commented on HARMONY-123:
---------------------------------------
Tim,
The fix is good. Please close this JIRA. Thanks a lot.
> Refactor: java.nio.charset.CharsetDecoder.decode
> ------------------------------------------------
>
> Key: HARMONY-123
> URL: http://issues.apache.org/jira/browse/HARMONY-123
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Richard Liang
> Assignee: Tim Ellison
> Priority: Minor
> Attachments: CharsetDecoder_patch.txt
>
> I've refactored two decode methods in CharsetDecode.java. Although the original version runs well, the structure of these two methods is messed. The refactored methods include:
> 1. public final CharBuffer decode(ByteBuffer in) throws CharacterCodingException;
> 2. public final CoderResult decode(ByteBuffer in, CharBuffer out,boolean endOfInput);
> Main changes:
> 1. remove embedded "while" in decode(ByteBuffer in, CharBuffer out,boolean endOfInput);
> 2. restruct condition control process in both two methods.
> 3. truncate return value of decode(in), which means the returned CharBuffer has the same value between capacity and limit.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira