You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/10/08 10:21:28 UTC
[GitHub] arina-ielchiieva commented on a change in pull request #1494: DRILL-6768: Improve to_date, to_time and to_timestamp and correspondi…
arina-ielchiieva commented on a change in pull request #1494: DRILL-6768: Improve to_date, to_time and to_timestamp and correspondi…
URL: https://github.com/apache/drill/pull/1494#discussion_r223313758
##########
File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/testing/TestDateConversions.java
##########
@@ -206,4 +210,100 @@ public void testPostgresDateFormatError() throws Exception {
throw e;
}
}
+
+ @Test
+ public void testToDateWithEmptyString() throws Exception {
+ try {
+ test("alter system set `drill.exec.functions.cast_empty_string_to_null` = true;");
+ Object[] nullObj = new Object[] {null};
+ testBuilder().sqlQuery("SELECT to_date(dateCol, 'yyyy-MM-dd') d from cp.`dateWithEmptyStrings.json`")
+ .unOrdered()
+ .baselineColumns("d")
+ .baselineValues(nullObj)
+ .baselineValues(nullObj)
+ .baselineValues(LocalDate.of(1997, 12, 10))
+ .go();
+ } finally {
+ test("alter system reset `drill.exec.functions.cast_empty_string_to_null`;");
+ }
+ }
+
+ @Test
+ public void testToTimeWithEmptyString() throws Exception {
+ try {
+ test("alter system set `drill.exec.functions.cast_empty_string_to_null` = true;");
+ Object[] nullObj = new Object[] {null};
+ testBuilder().sqlQuery("SELECT to_time(timeCol, 'hh:mm:ss') t from cp.`dateWithEmptyStrings.json`")
+ .unOrdered()
+ .baselineColumns("t")
+ .baselineValues(nullObj)
+ .baselineValues(nullObj)
+ .baselineValues(LocalTime.of(7, 21, 39))
+ .go();
+ } finally {
+ test("alter system reset `drill.exec.functions.cast_empty_string_to_null`;");
+ }
+ }
+
+ @Test
+ public void testToTimeStampWithEmptyString() throws Exception {
+ try {
+ test("alter system set `drill.exec.functions.cast_empty_string_to_null` = true;");
+ Object[] nullObj = new Object[] {null};
+ testBuilder().sqlQuery("SELECT to_timestamp(timestampCol, 'yyyy-MM-dd hh:mm:ss') t from cp.`dateWithEmptyStrings.json`")
+ .unOrdered()
+ .baselineColumns("t")
+ .baselineValues(nullObj)
+ .baselineValues(nullObj)
+ .baselineValues(LocalDateTime.of(2003, 9, 11, 10, 1, 37))
+ .go();
+ } finally {
+ test("alter system reset `drill.exec.functions.cast_empty_string_to_null`;");
+ }
+ }
+
+ @Test
+ public void testToDateWithLiteralEmptyString() throws Exception {
+ try {
+ test("alter system set `drill.exec.functions.cast_empty_string_to_null` = true;");
+ Object[] nullObj = new Object[] {null};
+ testBuilder().sqlQuery("SELECT to_date('', 'yyyy-MM-dd') d from (values(1))")
+ .unOrdered()
+ .baselineColumns("d")
+ .baselineValues(nullObj)
+ .go();
+ } finally {
+ test("alter system reset `drill.exec.functions.cast_empty_string_to_null`;");
+ }
+ }
+
+ @Test
+ public void testToTimeWithLiteralEmptyString() throws Exception {
+ try {
+ test("alter system set `drill.exec.functions.cast_empty_string_to_null` = true;");
+ Object[] nullObj = new Object[] {null};
+ testBuilder().sqlQuery("SELECT to_time('', 'hh:mm:ss') d from (values(1))")
+ .unOrdered()
+ .baselineColumns("d")
+ .baselineValues(nullObj)
+ .go();
+ } finally {
+ test("alter system reset `drill.exec.functions.cast_empty_string_to_null`;");
+ }
+ }
+
+ @Test
+ public void testToTimeStampWithLiteralEmptyString() throws Exception {
+ try {
+ test("alter system set `drill.exec.functions.cast_empty_string_to_null` = true;");
Review comment:
alterSesssion here and in all other tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services