You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by liu-zhaokun <gi...@git.apache.org> on 2017/06/21 05:26:04 UTC
[GitHub] storm pull request #2170: [STORM-2564] We should provide a template for stor...
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/storm/pull/2170
[STORM-2564] We should provide a template for storm-cluster-auth.yaml
[https://issues.apache.org/jira/browse/STORM-2564](https://issues.apache.org/jira/browse/STORM-2564)
As the configuration which named storm.zookeeper.auth.payload should be filled in "storm-cluster-auth.yaml",and there isn't such a file.So, I think we should provide a template for storm-cluster-auth.yaml.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liu-zhaokun/storm new3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2170.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2170
----
commit bd62e4cc25b3bb8bca17c372c8b5deb43f2456c1
Author: liuzhaokun <li...@zte.com.cn>
Date: 2017-06-21T05:24:32Z
[STORM-2564] We should provide a template for storm-cluster-auth.yaml
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2170: [STORM-2564] We should provide a template for storm-clust...
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2170
@vesense
Could you help me review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2170: [STORM-2564] We should provide a template for storm-clust...
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2170
@HeartSaVioR
Hello,are you available to help me review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2170: [STORM-2564] We should provide a template for stor...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2170
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2170: [STORM-2564] We should provide a template for storm-clust...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2170
@liu-zhaokun Thanks for correcting. You're right. I'm not aware of that. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2170: [STORM-2564] We should provide a template for storm-clust...
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2170
@HeartSaVioR
Users needn't copy the configuration,storm.zookeeper.auth.payload, from storm-cluster-auth.yaml.template and paste to their storm.yaml.They only should add this configuration to storm-cluster-auth.yaml if they need.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2170: [STORM-2564] We should provide a template for storm-clust...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2170
If this is needed, why not adding storm.yaml.example and commenting it out? I don't think users want to copy a line from template file and paste to their storm.yaml.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2170: [STORM-2564] We should provide a template for storm-clust...
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2170
@HeartSaVioR
It says "Note that if this is set to something with a secret (as when using digest authentication) then it should only be set in the storm-cluster-auth.yaml file." in Config.java,line 1082. So I think we should provide
a template.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2170: [STORM-2564] We should provide a template for storm-clust...
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2170
@HeartSaVioR
Thanks for your reply,if possible, please help me merge it as soon as possible,because this PR has been created for a long time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---