[GitHub] [arrow] pitrou commented on a change in pull request #7789: PARQUET-1878: [C++] lz4 codec is not compatible with Hadoop Lz4Codec

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#discussion_r456333439



##########
File path: cpp/src/parquet/reader_test.cc
##########
@@ -58,6 +58,63 @@ std::string nation_dict_truncated_data_page() {
   return data_file("nation.dict-malformed.parquet");
 }
 
+std::string hadoop_lz4_compressed() { return data_file("hadoop_lz4_compressed.parquet"); }
+
+// TODO: Assert on definition and repetition levels
+template <typename DType, typename ValueType>
+void ASSERT_BATCH_EQUAL(std::shared_ptr<TypedColumnReader<DType>> col, int64_t batch_size,

Review comment:
       Use CamelCase on function names. Also, not sure "Batch" is the right word (there may be confusion with Arrow record batches).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org