You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by gcaragea <gi...@git.apache.org> on 2016/01/12 21:01:26 UTC
[GitHub] incubator-hawq pull request: HAWQ-133. Remove MD Versioning code
GitHub user gcaragea opened a pull request:
https://github.com/apache/incubator-hawq/pull/261
HAWQ-133. Remove MD Versioning code
We will implement a simpler invalidation-based solution instead of versioning. This will be used by the Query Optimizer to manage Metadata Cache.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gcaragea/incubator-hawq gcaragea-remove-mdversioning
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/261.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #261
----
commit 0c320b5af1f508a5b9512a69701085f423b92245
Author: George Caragea <gc...@pivotal.io>
Date: 2016-01-12T19:33:36Z
[HAWQ-333] Remove Metadata Versioning code
commit 792723139bec40cc8aa78abcb9599739f56402ed
Author: George Caragea <gc...@pivotal.io>
Date: 2016-01-12T19:43:39Z
[HAWQ-333] Removed unit test relevant to Metadata Versioning
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-133. Remove MD Versioning code
Posted by gcaragea <gi...@git.apache.org>.
Github user gcaragea commented on the pull request:
https://github.com/apache/incubator-hawq/pull/261#issuecomment-171036638
@armenatzoglou @foyzur please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-133. Remove MD Versioning code
Posted by foyzur <gi...@git.apache.org>.
Github user foyzur commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/261#discussion_r49515049
--- Diff: src/backend/gpopt/translate/CTranslatorUtils.cpp ---
@@ -354,21 +353,16 @@ CTranslatorUtils::PmdidWithVersion
ullDDLv = 0;
--- End diff --
It's already initialized to 0. Do you need this code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-133. Remove MD Versioning code
Posted by foyzur <gi...@git.apache.org>.
Github user foyzur commented on the pull request:
https://github.com/apache/incubator-hawq/pull/261#issuecomment-171063587
LGTM. Any reason why we cannot revert the previous commits and let Git handle the cleanup job?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-133. Remove MD Versioning code
Posted by armenatzoglou <gi...@git.apache.org>.
Github user armenatzoglou commented on the pull request:
https://github.com/apache/incubator-hawq/pull/261#issuecomment-171066729
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-333. Remove MD Versioning code
Posted by gcaragea <gi...@git.apache.org>.
Github user gcaragea commented on the pull request:
https://github.com/apache/incubator-hawq/pull/261#issuecomment-171114793
I removed the extra GUCs and logging / instrumentation code. Please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-333. Remove MD Versioning code
Posted by gcaragea <gi...@git.apache.org>.
Github user gcaragea closed the pull request at:
https://github.com/apache/incubator-hawq/pull/261
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-333. Remove MD Versioning code
Posted by gcaragea <gi...@git.apache.org>.
Github user gcaragea commented on the pull request:
https://github.com/apache/incubator-hawq/pull/261#issuecomment-171115184
@foyzur The code is well contained, and this is easier than reverting a few tens of commits (in my opinion). Do you have any specific concern?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-333. Remove MD Versioning code
Posted by foyzur <gi...@git.apache.org>.
Github user foyzur commented on the pull request:
https://github.com/apache/incubator-hawq/pull/261#issuecomment-171117324
If it's 10s of commits, then it makes sense.
On Jan 12, 2016 4:55 PM, "George Caragea" <no...@github.com> wrote:
> @foyzur <https://github.com/foyzur> The code is well contained, and this
> is easier than reverting a few tens of commits (in my opinion). Do you have
> any specific concern?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-hawq/pull/261#issuecomment-171115184>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---