You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/02 17:46:32 UTC

[GitHub] [tvm] apivovarov commented on a diff in pull request #11178: [TRT] Add check to use setBindingDimensions if TRT>=6.0.1

apivovarov commented on code in PR #11178:
URL: https://github.com/apache/tvm/pull/11178#discussion_r863050743


##########
src/runtime/contrib/tensorrt/tensorrt_runtime.cc:
##########
@@ -163,12 +163,14 @@ class TensorRTRuntime : public JSONRuntimeBase {
           const std::string name = nodes_[nid].GetOpName() + "_" + std::to_string(j);
           int binding_index = engine->getBindingIndex(name.c_str());
           ICHECK_NE(binding_index, -1);
+#if TRT_VERSION_GE(6, 0, 1)

Review Comment:
   Below this code on [line 215](https://github.com/apache/tvm/blob/ceda892f081ceb39457394916a18f6e7045a1a8e/src/runtime/contrib/tensorrt/tensorrt_runtime.cc#L215) we just ignore use_implicit_batch_ flag if TRT <6.0.1.
   This PR applies the same logic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org