You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/10 20:30:00 UTC
[jira] [Work logged] (BEAM-3789) [SQL] Support Nested Rows
[ https://issues.apache.org/jira/browse/BEAM-3789?focusedWorklogId=79253&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-79253 ]
ASF GitHub Bot logged work on BEAM-3789:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Mar/18 20:29
Start Date: 10/Mar/18 20:29
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #4822: [BEAM-3789][SQL] Support nested Rows
URL: https://github.com/apache/beam/pull/4822#issuecomment-372063632
<img class="emoji" title=":lgtm:" alt=":lgtm:" align="absmiddle" src="https://reviewable.io/lgtm.png" height="20" width="61"/>
---
Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.
---
*[sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/BeamSqlFnExecutor.java, line 44 at r1](https://reviewable.io:443/reviews/apache/beam/4822#-L7G_-tB2t85K0bzwecj:-L7G_-tB2t85K0bzweck:b4c4jgi) ([raw file](https://github.com/apache/beam/blob/26105626e2bc2fa88f95d71be5583ee70b66e275/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/BeamSqlFnExecutor.java#L44)):*
> ```Java
> .BeamSqlPlusExpression;
> import org.apache.beam.sdk.extensions.sql.impl.interpreter.operator.comparison
> .BeamSqlEqualsExpression;
> ```
This is a bit weird
---
*[sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/operator/row/package-info.java, line 23 at r1](https://reviewable.io:443/reviews/apache/beam/4822#-L7G_Ckna86tlo3_jfCh:-L7G_Ckna86tlo3_jfCi:b-jj7gg9) ([raw file](https://github.com/apache/beam/blob/26105626e2bc2fa88f95d71be5583ee70b66e275/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/operator/row/package-info.java#L23)):*
> ```Java
> */
> @DefaultAnnotation(NonNull.class)
> package org.apache.beam.sdk.extensions.sql.impl.interpreter.operator.row;
> ```
I think we might be getting a bit extreme about nesting Java packages. I prefer to keep them as un-nested as possible so that package-private access is useful and it is easy to browse the whole system at a glance. Most tools are best at one directory at a time, up to a few dozen files.
---
*[sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslNestedRowsTest.java, line 200 at r1](https://reviewable.io:443/reviews/apache/beam/4822#-L7GaLhzvH_ioLa0XIUN:-L7GaLhzvH_ioLa0XIUO:b-4ek08r) ([raw file](https://github.com/apache/beam/blob/26105626e2bc2fa88f95d71be5583ee70b66e275/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslNestedRowsTest.java#L200)):*
> ```Java
> .apply(
> BeamSql.query(
> "SELECT `PCOLLECTION`.`f_nestedRow`.`f_nestedString` FROM PCOLLECTION"))
> ```
Now that there's also arrays, it would be nice to build some complex nesting and make sure it all works. This PR is fine now, but you do have to rebase to resolve the conflicts anyhow.
---
*Comments from [Reviewable](https://reviewable.io:443/reviews/apache/beam/4822#-:-L7GadAerQFXHsVyFnWI:bnfp4nl)*
<!-- Sent from Reviewable.io -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 79253)
Time Spent: 0.5h (was: 20m)
> [SQL] Support Nested Rows
> -------------------------
>
> Key: BEAM-3789
> URL: https://issues.apache.org/jira/browse/BEAM-3789
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Anton Kedin
> Assignee: Anton Kedin
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Add support for SqlTypeName.ROW
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)