You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/01/27 03:22:40 UTC

[GitHub] [druid] suneet-s opened a new pull request #9260: intelliJ inspections cleanup

suneet-s opened a new pull request #9260: intelliJ inspections cleanup
URL: https://github.com/apache/druid/pull/9260
 
 
   - remove redundant escapes
   - performance warnings
   - access static member via instance reference
   - static method declared final
   - inner class may be static
   
   Most of these changes are aesthetic, however, they will allow inspections to
   be enabled as part of CI checks going forward
   
   The valuable changes in this delta are:
   - using StringBuilder instead of string addition in a loop
       indexing-hadoop/.../Utils.java
       processing/.../ByteBufferMinMaxOffsetHeap.java
   - Use class variables instead of static variables for parameterized test
       processing/src/.../ScanQueryLimitRowIteratorTest.java

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] ccaominh commented on issue #9260: intelliJ inspections cleanup

Posted by GitBox <gi...@apache.org>.
ccaominh commented on issue #9260: intelliJ inspections cleanup
URL: https://github.com/apache/druid/pull/9260#issuecomment-578596701
 
 
   If all the inspection warnings have been fixed, consider updating the [Druid inspection profile](https://github.com/apache/druid/blob/master/.idea/inspectionProfiles/Druid.xml) to flag the relevant inspection types as errors so that CI prevents adding new occurrences.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] gianm merged pull request #9260: intelliJ inspections cleanup

Posted by GitBox <gi...@apache.org>.
gianm merged pull request #9260: intelliJ inspections cleanup
URL: https://github.com/apache/druid/pull/9260
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org