[GitHub] [cassandra] dcapwell commented on a change in pull request #1136: CASSANDRA-16850 - Add client warnings and abort to tombstone and coordinator reads which go past a low/high watermark

[GitBox <gi...@apache.org>]

dcapwell commented on a change in pull request #1136:
URL: https://github.com/apache/cassandra/pull/1136#discussion_r688096795



##########
File path: test/distributed/org/apache/cassandra/distributed/impl/InstanceMetrics.java
##########
@@ -45,16 +45,32 @@
         this.metricsRegistry = metricsRegistry;
     }
 
+    @Override
     public List<String> getNames()
     {
         return new ArrayList<>(metricsRegistry.getNames());
     }
 
+    @Override
     public long getCounter(String name)
     {
-        return metricsRegistry.getCounters().get(name).getCount();
+        Counter counter = metricsRegistry.getCounters().get(name);

Review comment:
       @ifesdjeen can you review this?  every metric has a counter but the current API doesn't allow access to it; my tests need access to a meter's counter




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org