You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/02/10 17:03:42 UTC

[GitHub] [kafka] OneCricketeer commented on a change in pull request #11746: MINOR: Use timeout config in KafkaAdminClient

OneCricketeer commented on a change in pull request #11746:
URL: https://github.com/apache/kafka/pull/11746#discussion_r803897385



##########
File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##########
@@ -524,7 +524,7 @@ static KafkaAdminClient createInternal(AdminClientConfig config, TimeoutProcesso
                 config.getLong(AdminClientConfig.RECONNECT_BACKOFF_MAX_MS_CONFIG),
                 config.getInt(AdminClientConfig.SEND_BUFFER_CONFIG),
                 config.getInt(AdminClientConfig.RECEIVE_BUFFER_CONFIG),
-                (int) TimeUnit.HOURS.toMillis(1),
+                config.getInt(AdminClientConfig.REQUEST_TIMEOUT_MS_CONFIG),

Review comment:
       Should this be a long like the other timeouts? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org