You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Norval Hope (JIRA)" <ji...@apache.org> on 2009/08/06 12:52:14 UTC
[jira] Created: (DIRSERVER-1395) '=' is being escaped properly in
RDN values
'=' is being escaped properly in RDN values
-------------------------------------------
Key: DIRSERVER-1395
URL: https://issues.apache.org/jira/browse/DIRSERVER-1395
Project: Directory ApacheDS
Issue Type: Bug
Components: ldap
Affects Versions: 1.0, 1.5.4
Environment: Windows XP
Reporter: Norval Hope
A colleague of mine discovered that due to a mistake in a boolean array (AttributeTypeAndValue.DN_ESCAPED_CHARS) the '=' character is not escaped during RDN normalization when it appears in a RDN value. This may be due to http://www.faqs.org/rfcs/rfc2253.html seemingly leaving it in "2.4. Converting an AttributeValue from ASN.1 to a String" but then including it in the "special = " BNF clause.
The attached patch fixes the problem, adds a new testcase covering it and fixes a few other testcases which tested for the old (broken) behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DIRSERVER-1395) '=' is being escaped properly in
RDN values
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny closed DIRSERVER-1395.
----------------------------------------
Resolution: Invalid
I confirm that '=' is not to be escaped in a RDN, at meast, it's not mandatory. RFC 4514, appendix B states so :
- Updated Section 2.4. Indicated that equals sign ('=' U+003D) character may
be escaped as '\='.
- Updated the Section 3 ABNF. Changes include:
+ did not require escaping of equals sign ('=' U+003D)
characters,
> '=' is being escaped properly in RDN values
> -------------------------------------------
>
> Key: DIRSERVER-1395
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1395
> Project: Directory ApacheDS
> Issue Type: Bug
> Components: ldap
> Affects Versions: 1.5.4, 1.0
> Environment: Windows XP
> Reporter: Norval Hope
> Attachments: rdn_value_with_equal.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> A colleague of mine discovered that due to a mistake in a boolean array (AttributeTypeAndValue.DN_ESCAPED_CHARS) the '=' character is not escaped during RDN normalization when it appears in a RDN value. This may be due to http://www.faqs.org/rfcs/rfc2253.html seemingly leaving it in "2.4. Converting an AttributeValue from ASN.1 to a String" but then including it in the "special = " BNF clause.
> The attached patch fixes the problem, adds a new testcase covering it and fixes a few other testcases which tested for the old (broken) behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSERVER-1395) '=' is being escaped properly in
RDN values
Posted by "Norval Hope (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Norval Hope updated DIRSERVER-1395:
-----------------------------------
Attachment: rdn_value_with_equal.patch
Patch against latest trunk (r801527).
> '=' is being escaped properly in RDN values
> -------------------------------------------
>
> Key: DIRSERVER-1395
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1395
> Project: Directory ApacheDS
> Issue Type: Bug
> Components: ldap
> Affects Versions: 1.5.4, 1.0
> Environment: Windows XP
> Reporter: Norval Hope
> Attachments: rdn_value_with_equal.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> A colleague of mine discovered that due to a mistake in a boolean array (AttributeTypeAndValue.DN_ESCAPED_CHARS) the '=' character is not escaped during RDN normalization when it appears in a RDN value. This may be due to http://www.faqs.org/rfcs/rfc2253.html seemingly leaving it in "2.4. Converting an AttributeValue from ASN.1 to a String" but then including it in the "special = " BNF clause.
> The attached patch fixes the problem, adds a new testcase covering it and fixes a few other testcases which tested for the old (broken) behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-1395) '=' is being escaped properly in
RDN values
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740003#action_12740003 ]
Emmanuel Lecharny commented on DIRSERVER-1395:
----------------------------------------------
RFC 4514 states clearly the the '=' should *not* be escaped :
distinguishedName = [ relativeDistinguishedName *( COMMA relativeDistinguishedName ) ]
relativeDistinguishedName = attributeTypeAndValue *( PLUS attributeTypeAndValue )
attributeTypeAndValue = attributeType EQUALS attributeValue
attributeValue = string / hexstring
; The following characters are to be escaped when they appear
; in the value to be encoded: ESC, one of <escaped>, leading
; SHARP or SPACE, trailing SPACE, and NULL.
string = [ ( leadchar / pair ) [ *( stringchar / pair ) ( trailchar / pair ) ] ]
leadchar = LUTF1 / UTFMB
LUTF1 = %x01-1F / %x21 / %x24-2A / %x2D-3A / %x3D / %x3F-5B / %x5D-7F ;; The ' ', '"', '#', '+', ',', ';', '<', '>' and '\' are not part of this list
trailchar = TUTF1 / UTFMB
TUTF1 = %x01-1F / %x21 / %x23-2A / %x2D-3A / %x3D / %x3F-5B / %x5D-7F ;; The ' ', '"', '#', '+', ',', ';', '<', '>' and '\' are not part of this list
stringchar = SUTF1 / UTFMB
SUTF1 = %x01-21 / %x23-2A / %x2D-3A / %x3D / %x3F-5B / %x5D-7F ;; The '"', '+', ',', ';', '<', '>' and '\' are not part of this list
pair = ESC ( ESC / special / hexpair )
special = escaped / SPACE / SHARP / EQUALS
escaped = DQUOTE / PLUS / COMMA / SEMI / LANGLE / RANGLE ;; The escaped chars are '"', ',', ';', '<' and '>'
hexstring = SHARP 1*hexpair
hexpair = HEX HEX
> '=' is being escaped properly in RDN values
> -------------------------------------------
>
> Key: DIRSERVER-1395
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1395
> Project: Directory ApacheDS
> Issue Type: Bug
> Components: ldap
> Affects Versions: 1.5.4, 1.0
> Environment: Windows XP
> Reporter: Norval Hope
> Attachments: rdn_value_with_equal.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> A colleague of mine discovered that due to a mistake in a boolean array (AttributeTypeAndValue.DN_ESCAPED_CHARS) the '=' character is not escaped during RDN normalization when it appears in a RDN value. This may be due to http://www.faqs.org/rfcs/rfc2253.html seemingly leaving it in "2.4. Converting an AttributeValue from ASN.1 to a String" but then including it in the "special = " BNF clause.
> The attached patch fixes the problem, adds a new testcase covering it and fixes a few other testcases which tested for the old (broken) behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.