[jira] [Commented] (LUCENE-4972) DirectoryTaxonomyWriter makes a commit even if no changes were made

["Michael McCandless (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-4972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647423#comment-13647423 ] 

Michael McCandless commented on LUCENE-4972:
--------------------------------------------

I wonder if instead of isDirty we could instead call IW.getCommitData() and check if the epoch hasn't changed?
                
> DirectoryTaxonomyWriter makes a commit even if no changes were made
> -------------------------------------------------------------------
>
>                 Key: LUCENE-4972
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4972
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/facet
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 5.0, 4.4
>
>         Attachments: LUCENE-4972.patch
>
>
> Now that IndexWriter allows committing changes even if the only change is setCommitData, DirectoryTaxonomyWriter creates empty commits because whenever you call commit/close, it sets as commitData the indexEpoch, thereby creating unnecessary commit points.
> I think that DirTaxoWriter should track if the index is dirty ... or preferably get that from IndexWriter (i.e. getChangeCount or something). I'll create a test case exposing the bug and then fix DTW.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org