You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/04/19 09:04:10 UTC

Review Request 46372: Fixed broken mesos.native package installation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46372/
-----------------------------------------------------------

Review request for mesos, Steve Niemitz, Till Toenshoff, and Vinod Kone.


Bugs: MESOS-4090
    https://issues.apache.org/jira/browse/MESOS-4090


Repository: mesos


Description
-------

Fixed broken mesos.native package installation.


Diffs
-----

  src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac 

Diff: https://reviews.apache.org/r/46372/diff/


Testing
-------


Thanks,

haosdent huang


Re: Review Request 46372: Fixed broken mesos.native package installation.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46372/#review129498
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46372]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 19, 2016, 7:04 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46372/
> -----------------------------------------------------------
> 
> (Updated April 19, 2016, 7:04 a.m.)
> 
> 
> Review request for mesos, Steve Niemitz, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-4090
>     https://issues.apache.org/jira/browse/MESOS-4090
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed broken mesos.native package installation.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac 
> 
> Diff: https://reviews.apache.org/r/46372/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Re: Review Request 46372: Fixed broken mesos.native package installation.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46372/#review129801
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On April 19, 2016, 9:12 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46372/
> -----------------------------------------------------------
> 
> (Updated April 19, 2016, 9:12 a.m.)
> 
> 
> Review request for mesos, Steve Niemitz, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-4090
>     https://issues.apache.org/jira/browse/MESOS-4090
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed broken mesos.native package installation.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac 
> 
> Diff: https://reviews.apache.org/r/46372/diff/
> 
> 
> Testing
> -------
> 
> * `make install` and local test in CentOS 7.2
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Re: Review Request 46372: Fixed broken mesos.native package installation.

Posted by Steve Niemitz <sn...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46372/#review130017
-----------------------------------------------------------


Ship it!




Ship It!

- Steve Niemitz


On April 22, 2016, 1:22 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46372/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 1:22 a.m.)
> 
> 
> Review request for mesos, Steve Niemitz, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-5233
>     https://issues.apache.org/jira/browse/MESOS-5233
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed broken mesos.native package installation.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac 
> 
> Diff: https://reviews.apache.org/r/46372/diff/
> 
> 
> Testing
> -------
> 
> * `make install` and local test in CentOS 7.2
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Re: Review Request 46372: Fixed broken mesos.native package installation.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46372/
-----------------------------------------------------------

(Updated April 22, 2016, 1:22 a.m.)


Review request for mesos, Steve Niemitz, Till Toenshoff, and Vinod Kone.


Changes
-------

fixed the bug id -- @vinodkone


Bugs: MESOS-5233
    https://issues.apache.org/jira/browse/MESOS-5233


Repository: mesos


Description
-------

Fixed broken mesos.native package installation.


Diffs
-----

  src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac 

Diff: https://reviews.apache.org/r/46372/diff/


Testing
-------

* `make install` and local test in CentOS 7.2


Thanks,

haosdent huang


Re: Review Request 46372: Fixed broken mesos.native package installation.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46372/
-----------------------------------------------------------

(Updated April 19, 2016, 9:12 a.m.)


Review request for mesos, Steve Niemitz, Till Toenshoff, and Vinod Kone.


Changes
-------

Update test done field.


Bugs: MESOS-4090
    https://issues.apache.org/jira/browse/MESOS-4090


Repository: mesos


Description
-------

Fixed broken mesos.native package installation.


Diffs
-----

  src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac 

Diff: https://reviews.apache.org/r/46372/diff/


Testing (updated)
-------

* `make install` and local test in CentOS 7.2


Thanks,

haosdent huang