You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ly...@apache.org on 2022/07/22 17:07:21 UTC

[superset] 15/39: Fixes for DartasourceControl Test Suite

This is an automated email from the ASF dual-hosted git repository.

lyndsi pushed a commit to branch lyndsi/sql-lab-new-explore-button-functionality-and-move-save-dataset-to-split-save-button
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 82947c37cf78f55b7d594b08dbafe7979a89549c
Author: Eric Briscoe <er...@gmail.com>
AuthorDate: Tue Jun 28 15:38:26 2022 -0700

    Fixes for DartasourceControl Test Suite
---
 .../explore/components/controls/DatasourceControl/index.jsx   | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx b/superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx
index 012241a209..5816563215 100644
--- a/superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx
+++ b/superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx
@@ -169,17 +169,6 @@ class DatasourceControl extends React.PureComponent {
     };
   }
 
-  getDatasourceAsSaveableDataset = source => {
-    const dataset = {
-      columns: source?.columns || [],
-      name: source?.datasource_name || t('Untitled'),
-      dbId: source.database.id,
-      sql: source?.sql || '',
-      schema: source?.schema,
-    };
-    return dataset;
-  };
-
   onDatasourceSave = datasource => {
     this.props.actions.changeDatasource(datasource);
     const timeCol = this.props.form_data?.granularity_sqla;