You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/03/10 03:40:53 UTC
[GitHub] [kylin] zhoukangcn opened a new pull request #1152: KYLIN-4413: add
canary tool
zhoukangcn opened a new pull request #1152: KYLIN-4413: add canary tool
URL: https://github.com/apache/kylin/pull/1152
https://issues.apache.org/jira/browse/KYLIN-4413
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] shaofengshi commented on a change in pull request #1152:
KYLIN-4413: add canary tool
Posted by GitBox <gi...@apache.org>.
shaofengshi commented on a change in pull request #1152: KYLIN-4413: add canary tool
URL: https://github.com/apache/kylin/pull/1152#discussion_r390773210
##########
File path: tool/src/main/java/org/apache/kylin/tool/KylinCanary.java
##########
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kylin.tool;
+
+
+import org.apache.commons.cli.Options;
+import org.apache.commons.configuration.SubsetConfiguration;
+import org.apache.hadoop.metrics2.MetricsRecord;
+import org.apache.hadoop.metrics2.MetricsSink;
+import org.apache.hadoop.metrics2.MetricsSystem;
+import org.apache.hadoop.metrics2.annotation.Metric;
+import org.apache.hadoop.metrics2.annotation.Metrics;
+import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem;
+import org.apache.hadoop.metrics2.lib.MutableGaugeLong;
+import org.apache.http.HttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.DefaultHttpClient;
+import org.apache.http.params.BasicHttpParams;
+import org.apache.http.params.HttpConnectionParams;
+import org.apache.http.params.HttpParams;
+import org.apache.http.util.EntityUtils;
+import org.apache.kylin.common.KylinConfig;
+import org.apache.kylin.common.util.AbstractApplication;
+import org.apache.kylin.common.util.OptionsHelper;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+
+public class KylinCanary extends AbstractApplication {
+ private static final Logger logger = LoggerFactory.getLogger(KylinCanary.class);
+
+ private static final int HTTP_CONNECTION_TIMEOUT = 3000;
+ private static final int HTTP_READ_TIMEOUT = 30000;
+
+ private MetricsSink sink;
+ private KylinConfig config;
+ private long interval;
+ private String token;
+ private CanaryMetrics canaryMetrics;
+ private MetricsSystem metricsSystem;
+
+ @Metrics(name = "canary", about = "Canary metrics", context = "kylin")
+ public static class CanaryMetrics {
+ @Metric
+ MutableGaugeLong queryAvailability;
+
+ public CanaryMetrics() {
+ }
+
+ public void setQueryAvailability(long value) {
+ queryAvailability.set(value);
+ }
+ }
+
+ public KylinCanary() {
+ config = KylinConfig.getInstanceFromEnv();
+ token = config.getCanaryToken();
+
+ if (config.isCanaryDaemon()) {
+ interval = config.getCanaryInterval();
+ } else {
+ interval = -1;
+ }
+
+ canaryMetrics = new CanaryMetrics();
+ String sinkClassName = config.getCanarySinkClass();
+ try {
+ sink = (MetricsSink) Class.forName(sinkClassName).getConstructor().newInstance();
+ } catch (Exception e) {
+ logger.warn("new class: " + sinkClassName + " error.", e);
+ sink = new StdOutSink();
+ }
+ sink.init(null);
+
+ metricsSystem = DefaultMetricsSystem.instance();
+
+ metricsSystem.init("kylin-canary");
+ metricsSystem.register("kylin-canary", "Kylin Canary", canaryMetrics);
+ metricsSystem.register("falcon", "Falcon sink for xiaomi", sink);
+ }
+
+ @Override
+ protected Options getOptions() {
+ return new Options();
+ }
+
+ @Override
+ protected void execute(OptionsHelper optionsHelper) throws Exception {
+ if (interval > 0) {
+ while (true) {
+ runOnce();
+ }
+ } else {
+ runOnce();
+ }
+
+ metricsSystem.shutdown();
+ }
+
+ private void runOnce() throws InterruptedException {
+ long startTime = System.currentTimeMillis();
+
+ String[] servers = config.getRestServers();
+
+ // skip job server
+ // should use zookeeper info instead
+ int total = 0;
+ int failed = 0;
+ for (int i = 1; i < servers.length; i++) {
+ total++;
+ try {
+ checkQuery(servers[i]);
+ } catch (IOException e) {
+ failed++;
+ logger.warn("check failed with error, ", e);
+ }
+ }
+
+ double avail = 0.0;
+ if (total == 0){
+ avail = 1.0;
+ } else {
+ avail = 1.0 - (failed / total);
+ }
+ canaryMetrics.setQueryAvailability((long)(avail * 100));
+
+ metricsSystem.publishMetricsNow();
+
+ long finishTime = System.currentTimeMillis();
+ logger.info("Finish one turn, consume(ms)=" + (finishTime - startTime)
+ + ", interval(ms)=" + interval);
+ if (finishTime < startTime + interval) {
+ Thread.sleep(startTime + interval - finishTime);
+ }
+ }
+
+ private HttpResponse makeHttpRequest(String url, String postContent) throws IOException {
+ HttpParams httpParams = new BasicHttpParams();
+ HttpConnectionParams.setConnectionTimeout(httpParams, HTTP_CONNECTION_TIMEOUT);
+ HttpConnectionParams.setSoTimeout(httpParams, HTTP_READ_TIMEOUT);
+ DefaultHttpClient httpClient = new DefaultHttpClient(httpParams);
+
+ HttpPost httpPost = new HttpPost(url);
+ StringEntity requestEntity = new StringEntity(postContent, ContentType.APPLICATION_JSON);
+ httpPost.setEntity(requestEntity);
+ httpPost.addHeader("Authorization", "Basic " + token);
+
+ HttpResponse response = httpClient.execute(httpPost);
+
+ return response;
+ }
+
+ private long checkQuery(String host) throws IOException {
+ long startTime = System.currentTimeMillis();
+ String url = "http://" + host + "/kylin/api/query";
+
+ HttpResponse response = makeHttpRequest(url,
+ "{\"sql\": \"SELECT 1\",\"project\": \"KYLIN_SYSTEM\"}");
+
+ int code = response.getStatusLine().getStatusCode();
Review comment:
Using org.apache.kylin.common.restclient.RestClient might be a better solution
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] shaofengshi commented on a change in pull request #1152:
KYLIN-4413: add canary tool
Posted by GitBox <gi...@apache.org>.
shaofengshi commented on a change in pull request #1152: KYLIN-4413: add canary tool
URL: https://github.com/apache/kylin/pull/1152#discussion_r390772293
##########
File path: tool/src/main/java/org/apache/kylin/tool/KylinCanary.java
##########
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kylin.tool;
+
+
+import org.apache.commons.cli.Options;
+import org.apache.commons.configuration.SubsetConfiguration;
+import org.apache.hadoop.metrics2.MetricsRecord;
+import org.apache.hadoop.metrics2.MetricsSink;
+import org.apache.hadoop.metrics2.MetricsSystem;
+import org.apache.hadoop.metrics2.annotation.Metric;
+import org.apache.hadoop.metrics2.annotation.Metrics;
+import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem;
+import org.apache.hadoop.metrics2.lib.MutableGaugeLong;
+import org.apache.http.HttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.DefaultHttpClient;
+import org.apache.http.params.BasicHttpParams;
+import org.apache.http.params.HttpConnectionParams;
+import org.apache.http.params.HttpParams;
+import org.apache.http.util.EntityUtils;
+import org.apache.kylin.common.KylinConfig;
+import org.apache.kylin.common.util.AbstractApplication;
+import org.apache.kylin.common.util.OptionsHelper;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+
+public class KylinCanary extends AbstractApplication {
+ private static final Logger logger = LoggerFactory.getLogger(KylinCanary.class);
+
+ private static final int HTTP_CONNECTION_TIMEOUT = 3000;
+ private static final int HTTP_READ_TIMEOUT = 30000;
+
+ private MetricsSink sink;
+ private KylinConfig config;
+ private long interval;
+ private String token;
+ private CanaryMetrics canaryMetrics;
+ private MetricsSystem metricsSystem;
+
+ @Metrics(name = "canary", about = "Canary metrics", context = "kylin")
+ public static class CanaryMetrics {
+ @Metric
+ MutableGaugeLong queryAvailability;
+
+ public CanaryMetrics() {
+ }
+
+ public void setQueryAvailability(long value) {
+ queryAvailability.set(value);
+ }
+ }
+
+ public KylinCanary() {
+ config = KylinConfig.getInstanceFromEnv();
+ token = config.getCanaryToken();
+
+ if (config.isCanaryDaemon()) {
+ interval = config.getCanaryInterval();
+ } else {
+ interval = -1;
+ }
+
+ canaryMetrics = new CanaryMetrics();
+ String sinkClassName = config.getCanarySinkClass();
+ try {
+ sink = (MetricsSink) Class.forName(sinkClassName).getConstructor().newInstance();
+ } catch (Exception e) {
+ logger.warn("new class: " + sinkClassName + " error.", e);
+ sink = new StdOutSink();
+ }
+ sink.init(null);
+
+ metricsSystem = DefaultMetricsSystem.instance();
+
+ metricsSystem.init("kylin-canary");
+ metricsSystem.register("kylin-canary", "Kylin Canary", canaryMetrics);
+ metricsSystem.register("falcon", "Falcon sink for xiaomi", sink);
Review comment:
Change a general name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] shaofengshi commented on a change in pull request #1152:
KYLIN-4413: add canary tool
Posted by GitBox <gi...@apache.org>.
shaofengshi commented on a change in pull request #1152: KYLIN-4413: add canary tool
URL: https://github.com/apache/kylin/pull/1152#discussion_r390771814
##########
File path: tool/src/main/java/org/apache/kylin/tool/KylinCanary.java
##########
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kylin.tool;
+
+
+import org.apache.commons.cli.Options;
+import org.apache.commons.configuration.SubsetConfiguration;
+import org.apache.hadoop.metrics2.MetricsRecord;
+import org.apache.hadoop.metrics2.MetricsSink;
+import org.apache.hadoop.metrics2.MetricsSystem;
+import org.apache.hadoop.metrics2.annotation.Metric;
+import org.apache.hadoop.metrics2.annotation.Metrics;
+import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem;
+import org.apache.hadoop.metrics2.lib.MutableGaugeLong;
+import org.apache.http.HttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.DefaultHttpClient;
+import org.apache.http.params.BasicHttpParams;
+import org.apache.http.params.HttpConnectionParams;
+import org.apache.http.params.HttpParams;
+import org.apache.http.util.EntityUtils;
+import org.apache.kylin.common.KylinConfig;
+import org.apache.kylin.common.util.AbstractApplication;
+import org.apache.kylin.common.util.OptionsHelper;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+
+public class KylinCanary extends AbstractApplication {
+ private static final Logger logger = LoggerFactory.getLogger(KylinCanary.class);
+
+ private static final int HTTP_CONNECTION_TIMEOUT = 3000;
+ private static final int HTTP_READ_TIMEOUT = 30000;
+
+ private MetricsSink sink;
+ private KylinConfig config;
+ private long interval;
+ private String token;
+ private CanaryMetrics canaryMetrics;
+ private MetricsSystem metricsSystem;
+
+ @Metrics(name = "canary", about = "Canary metrics", context = "kylin")
+ public static class CanaryMetrics {
+ @Metric
+ MutableGaugeLong queryAvailability;
+
+ public CanaryMetrics() {
+ }
+
+ public void setQueryAvailability(long value) {
+ queryAvailability.set(value);
+ }
+ }
+
+ public KylinCanary() {
+ config = KylinConfig.getInstanceFromEnv();
+ token = config.getCanaryToken();
+
+ if (config.isCanaryDaemon()) {
+ interval = config.getCanaryInterval();
+ } else {
+ interval = -1;
+ }
+
+ canaryMetrics = new CanaryMetrics();
+ String sinkClassName = config.getCanarySinkClass();
+ try {
+ sink = (MetricsSink) Class.forName(sinkClassName).getConstructor().newInstance();
+ } catch (Exception e) {
+ logger.warn("new class: " + sinkClassName + " error.", e);
+ sink = new StdOutSink();
+ }
+ sink.init(null);
+
+ metricsSystem = DefaultMetricsSystem.instance();
+
+ metricsSystem.init("kylin-canary");
+ metricsSystem.register("kylin-canary", "Kylin Canary", canaryMetrics);
+ metricsSystem.register("falcon", "Falcon sink for xiaomi", sink);
+ }
+
+ @Override
+ protected Options getOptions() {
+ return new Options();
+ }
+
+ @Override
+ protected void execute(OptionsHelper optionsHelper) throws Exception {
+ if (interval > 0) {
+ while (true) {
+ runOnce();
+ }
+ } else {
+ runOnce();
+ }
+
+ metricsSystem.shutdown();
+ }
+
+ private void runOnce() throws InterruptedException {
+ long startTime = System.currentTimeMillis();
+
+ String[] servers = config.getRestServers();
+
+ // skip job server
+ // should use zookeeper info instead
+ int total = 0;
+ int failed = 0;
+ for (int i = 1; i < servers.length; i++) {
+ total++;
+ try {
+ checkQuery(servers[i]);
+ } catch (IOException e) {
+ failed++;
+ logger.warn("check failed with error, ", e);
+ }
+ }
+
+ double avail = 0.0;
+ if (total == 0){
+ avail = 1.0;
+ } else {
+ avail = 1.0 - (failed / total);
+ }
+ canaryMetrics.setQueryAvailability((long)(avail * 100));
+
+ metricsSystem.publishMetricsNow();
+
+ long finishTime = System.currentTimeMillis();
+ logger.info("Finish one turn, consume(ms)=" + (finishTime - startTime)
+ + ", interval(ms)=" + interval);
+ if (finishTime < startTime + interval) {
+ Thread.sleep(startTime + interval - finishTime);
+ }
+ }
+
+ private HttpResponse makeHttpRequest(String url, String postContent) throws IOException {
+ HttpParams httpParams = new BasicHttpParams();
+ HttpConnectionParams.setConnectionTimeout(httpParams, HTTP_CONNECTION_TIMEOUT);
+ HttpConnectionParams.setSoTimeout(httpParams, HTTP_READ_TIMEOUT);
+ DefaultHttpClient httpClient = new DefaultHttpClient(httpParams);
+
+ HttpPost httpPost = new HttpPost(url);
+ StringEntity requestEntity = new StringEntity(postContent, ContentType.APPLICATION_JSON);
+ httpPost.setEntity(requestEntity);
+ httpPost.addHeader("Authorization", "Basic " + token);
+
+ HttpResponse response = httpClient.execute(httpPost);
+
+ return response;
+ }
+
+ private long checkQuery(String host) throws IOException {
+ long startTime = System.currentTimeMillis();
+ String url = "http://" + host + "/kylin/api/query";
+
+ HttpResponse response = makeHttpRequest(url,
+ "{\"sql\": \"SELECT 1\",\"project\": \"KYLIN_SYSTEM\"}");
Review comment:
The project "KYLIN_SYSTEM" may not exist ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] zhoukangcn commented on issue #1152: KYLIN-4413: add canary
tool
Posted by GitBox <gi...@apache.org>.
zhoukangcn commented on issue #1152: KYLIN-4413: add canary tool
URL: https://github.com/apache/kylin/pull/1152#issuecomment-597495832
> How to use this canary tool? Seems it need to be integrated with some monitoring tool. And, is this an extensible design so that more test can be added to it later?
Thank you @shaofengshi
I will add some tests later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] shaofengshi commented on a change in pull request #1152:
KYLIN-4413: add canary tool
Posted by GitBox <gi...@apache.org>.
shaofengshi commented on a change in pull request #1152: KYLIN-4413: add canary tool
URL: https://github.com/apache/kylin/pull/1152#discussion_r390772799
##########
File path: core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##########
@@ -2475,4 +2475,21 @@ public int getStaleJobThresholdInDays() {
public String getIntersectFilterOrSeparator() {
return getOptional("kylin.query.intersect.separator", "|");
}
+
+ public String getCanarySinkClass() {
+ return getOptional("kylin.canary.sink.class", "org.apache.kylin.tool.KylinCanary$StdOutSink");
+ }
+
+ public boolean isCanaryDaemon() {
+ return Boolean.parseBoolean(getOptional("kylin.canary.daemon", FALSE));
+ }
+
+ public long getCanaryInterval() {
+ return Long.parseLong(getOptional("kylin.canary.interval", "6000"));
+ }
+
+ public String getCanaryToken() {
+ return getOptional("kylin.canary.token", "");
Review comment:
Keep the basic auth in configuration file will increase the credential exposure risk. Is there a better way to do the authentication?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] zhoukangcn edited a comment on issue #1152: KYLIN-4413: add
canary tool
Posted by GitBox <gi...@apache.org>.
zhoukangcn edited a comment on issue #1152: KYLIN-4413: add canary tool
URL: https://github.com/apache/kylin/pull/1152#issuecomment-597495832
> How to use this canary tool? Seems it need to be integrated with some monitoring tool. And, is this an extensible design so that more test can be added to it later?
Thank you @shaofengshi
I will update later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls commented on issue #1152: KYLIN-4413: add canary
tool
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1152: KYLIN-4413: add canary tool
URL: https://github.com/apache/kylin/pull/1152#issuecomment-596943395
## Pull Request Test Coverage Report for [Build 5728](https://coveralls.io/builds/29242262)
* **0** of **84** **(0.0%)** changed or added relevant lines in **2** files are covered.
* **8** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.03%**) to **27.488%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/29242262/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L2480) | 0 | 4 | 0.0%
| [tool/src/main/java/org/apache/kylin/tool/KylinCanary.java](https://coveralls.io/builds/29242262/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2FKylinCanary.java#L49) | 0 | 80 | 0.0%
<!-- | **Total:** | **0** | **84** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/29242262/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
| [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/29242262/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/29242262/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
<!-- | **Total:** | **8** | | -->
| Totals | [](https://coveralls.io/builds/29242262) |
| :-- | --: |
| Change from base [Build 5720](https://coveralls.io/builds/29194855): | -0.03% |
| Covered Lines: | 24296 |
| Relevant Lines: | 88389 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls edited a comment on issue #1152: KYLIN-4413: add
canary tool
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1152: KYLIN-4413: add canary tool
URL: https://github.com/apache/kylin/pull/1152#issuecomment-596943395
## Pull Request Test Coverage Report for [Build 5744](https://coveralls.io/builds/29270887)
* **0** of **86** **(0.0%)** changed or added relevant lines in **2** files are covered.
* **10** unchanged lines in **4** files lost coverage.
* Overall coverage decreased (**-0.03%**) to **27.485%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/29270887/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L2480) | 0 | 4 | 0.0%
| [tool/src/main/java/org/apache/kylin/tool/KylinCanary.java](https://coveralls.io/builds/29270887/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2FKylinCanary.java#L50) | 0 | 82 | 0.0%
<!-- | **Total:** | **0** | **86** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/29270887/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
| [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/29270887/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% |
| [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/29270887/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/29270887/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
<!-- | **Total:** | **10** | | -->
| Totals | [](https://coveralls.io/builds/29270887) |
| :-- | --: |
| Change from base [Build 5720](https://coveralls.io/builds/29194855): | -0.03% |
| Covered Lines: | 24294 |
| Relevant Lines: | 88391 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services