[GitHub] [maven] mthmulders commented on pull request #659: [MNG-7390] Allow selecting modules outside the cwd into the reactor using --projects.

[GitBox <gi...@apache.org>]

mthmulders commented on pull request #659:
URL: https://github.com/apache/maven/pull/659#issuecomment-1038318518


   > The change in essence is very simple.
   This is about it: https://github.com/apache/maven/compare/master...MartinKanters:MNG-7390-select-module-outside-pwd-simplified
   
   Thanks, that is very helpful! The essence of the change is indeed pretty simple and I can make sense out of that.
   
   > [...] since we have covered it with a lot of unit tests and integration tests I had confidence that I could make the refactor
   
   That's what we have those tests for :-)
   
   I'm OK with the changes in the "simplified" version. Given that the tests all pass, I'm fine with merging the changes.
   
   Just a thought: would it be feasible to merge the simplified changes, and then have the refactoring as a separate PR, just to make it easier for everybody to follow along and review? I'd prefer to keep everyone involved as this is a piece of the code which is pretty hard to understand in itself...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org