You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/03/18 23:08:19 UTC
[kudu-CR](branch-1.9.x) KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12786
to review the following change.
Change subject: KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
......................................................................
KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
Added a test to reproduce deadlock when fork()-ed but not yet
exec()-ed subprocess tries to log on a failed execve() call.
The test is disabled because it fails. The follow-up
changelist will fix the problem and re-enable the test.
Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Reviewed-on: http://gerrit.cloudera.org:8080/12740
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit 33479893bd6037c463e7cb89b08e1e016565e2c3)
(cherry picked from commit 4bec64a8e0c22924d1addce8d19942147b191391)
---
M src/kudu/util/subprocess-test.cc
1 file changed, 46 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/12786/1
--
To view, visit http://gerrit.cloudera.org:8080/12786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Gerrit-Change-Number: 12786
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.9.x) KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12786 )
Change subject: KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Gerrit-Change-Number: 12786
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Mar 2019 17:44:21 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.9.x) KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12786 )
Change subject: KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/12786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Gerrit-Change-Number: 12786
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR](branch-1.9.x) KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12786 )
Change subject: KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
......................................................................
KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
Added a test to reproduce deadlock when fork()-ed but not yet
exec()-ed subprocess tries to log on a failed execve() call.
The test is disabled because it fails. The follow-up
changelist will fix the problem and re-enable the test.
Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Reviewed-on: http://gerrit.cloudera.org:8080/12740
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit 33479893bd6037c463e7cb89b08e1e016565e2c3)
(cherry picked from commit 4bec64a8e0c22924d1addce8d19942147b191391)
Reviewed-on: http://gerrit.cloudera.org:8080/12786
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/util/subprocess-test.cc
1 file changed, 46 insertions(+), 0 deletions(-)
Approvals:
Alexey Serbin: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Gerrit-Change-Number: 12786
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR](branch-1.9.x) KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12786 )
Change subject: KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
......................................................................
Patch Set 1: Verified+1
Unrelated flake in DeleteTabletITest.TestLeaderElectionDuringDeleteTablet
--
To view, visit http://gerrit.cloudera.org:8080/12786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Gerrit-Change-Number: 12786
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Mar 2019 16:36:55 +0000
Gerrit-HasComments: No