You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/07 11:01:22 UTC

[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #428: [FLINK-29851] Correctly depend on flink-kubernetes-standalone shaded classifier

gyfora opened a new pull request, #428:
URL: https://github.com/apache/flink-kubernetes-operator/pull/428

   ## What is the purpose of the change
   
   Fix the `flink-kubernetes-standalone` dependency in the `flink-kubernetes-operator` submodule to actually use the shaded classifier which is required to avoid fabric8 conflicts when running from IntelliJ (and it's also the actual dependency we use at runtime also)
   
   ## Brief change log
   
   This change is already covered by existing e2e tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): yes
     - The public API, i.e., is any changes to the `CustomResourceDescriptors`: no
     - Core observer or reconciler logic that is regularly executed: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #428: [FLINK-29851] Correctly depend on flink-kubernetes-standalone shaded classifier

Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #428:
URL: https://github.com/apache/flink-kubernetes-operator/pull/428#issuecomment-1305904048

   +1 LGTM. If you feel so you can add a third option to the docs too that ignores the standalone module's pom.xml:
   `Preferences > Build, Execution,Deployment > Build Tooles > Maven > Ignored Files`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #428: [FLINK-29851] Correctly depend on flink-kubernetes-standalone shaded classifier

Posted by GitBox <gi...@apache.org>.
gyfora merged PR #428:
URL: https://github.com/apache/flink-kubernetes-operator/pull/428


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #428: [FLINK-29851] Correctly depend on flink-kubernetes-standalone shaded classifier

Posted by GitBox <gi...@apache.org>.
gyfora commented on PR #428:
URL: https://github.com/apache/flink-kubernetes-operator/pull/428#issuecomment-1305463633

   cc @morhidi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org