You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/11/06 13:25:56 UTC

[GitHub] [commons-collections] garydgregory commented on a diff in pull request #357: Added Hasher.isEmpty() and appropriate tests

garydgregory commented on code in PR #357:
URL: https://github.com/apache/commons-collections/pull/357#discussion_r1014829652


##########
src/test/java/org/apache/commons/collections4/bloomfilter/EnhancedDoubleHasherTest.java:
##########
@@ -52,6 +53,11 @@ protected int getHasherSize(Hasher hasher) {
         return 1;
     }
 
+    @Override
+    public void testIsEmpty() {
+        assertFalse( createHasher().isEmpty() );

Review Comment:
   No extra spaces around parens.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org