You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by akedin <gi...@git.apache.org> on 2017/11/06 23:50:48 UTC
[GitHub] beam pull request #4087: Nexmark Generator refactor
GitHub user akedin opened a pull request:
https://github.com/apache/beam/pull/4087
Nexmark Generator refactor
Extracting separate pieces out of main Generator class to make it a bit easier to understand. No changes to the logic are introduced, just moving the code around.
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/akedin/beam nexmark-generator-refactor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/4087.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4087
----
commit 3f46c5cd3ef9f6ffcf0708b68cc40426350241ff
Author: Anton Kedin <ke...@google.com>
Date: 2017-11-06T22:47:38Z
[Nexmark] Extract GeneratorCheckpoint into a separate class. Move getNextEvent() call to the top of the stack.
commit 4557316465182df4df674470d9655a22f31f5390
Author: Anton Kedin <ke...@google.com>
Date: 2017-11-06T23:01:58Z
[Nexmark] Extract PersonGenerator, StringsGenerator, LongGenerator from Generator
commit 935b4822c703ecfac7a0819333150fe3bbd62380
Author: Anton Kedin <ke...@google.com>
Date: 2017-11-06T23:12:53Z
[Nexmark] Extract AuctionGenerator, PriceGenerator from Generator
commit dd2591661935e2ce1c9472d2dd9c401e3011ec9a
Author: Anton Kedin <ke...@google.com>
Date: 2017-11-06T23:19:39Z
[Nexmark] Extract BidGenerator from Generator
----
---
[GitHub] beam pull request #4087: [BEAM-3147] Nexmark Generator refactor
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/4087
---