You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Avery Ching <av...@gmail.com> on 2012/11/30 02:30:15 UTC
Review Request: GIRAPH-438: When checkpointing is disable, fast fail
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8287/
-----------------------------------------------------------
Review request for giraph.
Description
-------
Add a minor check before job submission on the checkpoint frequency and set max task attempts to 0 if checkpoint frequency is 0. Notifies the user as well.
This addresses bug GIRAPH-438.
https://issues.apache.org/jira/browse/GIRAPH-438
Diffs
-----
http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/GiraphConfiguration.java 1414463
http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/benchmark/RandomMessageBenchmark.java 1414463
http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/BspService.java 1414463
http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/GiraphJob.java 1414463
http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apache/giraph/TestAutoCheckpoint.java 1414463
http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apache/giraph/TestManualCheckpoint.java 1414463
http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apache/giraph/graph/TestAggregatorsHandling.java 1414463
Diff: https://reviews.apache.org/r/8287/diff/
Testing
-------
mvn clean install
Ran a page rank benchmark job to verify the number of attempts goes to 0 when the checkpoint frequency is 0.
Thanks,
Avery Ching