[jira] [Commented] (YARN-9883) Reshape SchedulerHealth class

["D M Murali Krishna Reddy (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-9883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235959#comment-17235959 ] 

D M Murali Krishna Reddy commented on YARN-9883:
------------------------------------------------

[~BilwaST] I have uploaded the patch, can you review the patch

> Reshape SchedulerHealth class
> -----------------------------
>
>                 Key: YARN-9883
>                 URL: https://issues.apache.org/jira/browse/YARN-9883
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager, yarn
>    Affects Versions: 3.3.0
>            Reporter: Adam Antal
>            Assignee: D M Murali Krishna Reddy
>            Priority: Minor
>         Attachments: YARN-9883.001.patch
>
>
> The {{SchedulerHealth}} class has some flaws, for example:
> - It has no javadoc at all
> - All its objects are package-private: they should be private
> - The internal maps should be (Concurrent) EnumMaps instead of HashMaps: they are more efficient in storing Enums
> - schedulerHealthDetails only stores the last operation, its name should reflect that (just like lastSchedulerRunDetails)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org