You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/02 19:20:07 UTC

[GitHub] [arrow-rs] mgill25 edited a comment on issue #230: Add support for pretty-printing Decimal numbers

mgill25 edited a comment on issue #230:
URL: https://github.com/apache/arrow-rs/issues/230#issuecomment-830857889


   Hi @alamb I'd like to take this issue up if that's ok.
   
   Looks like the change should be simple enough - just add the `Decimal` pattern to the  match expression. I have a silly question however: Is this being tested somewhere?
   
   Seems like there is no test in `display.rs`, but there _are_ tests in `pretty.rs`. Which I tried to run these tests, it seems cargo is skipping them, and yet it doesn't skip the tests in other neighboring modules.
   
   <img width="1257" alt="Screenshot 2021-05-02 at 21 14 50" src="https://user-images.githubusercontent.com/1311924/116824681-c8a51d00-ab8b-11eb-8f33-03a6cfafe8c9.png">
   
   Am I overthinking this a bit? Let me know how to figure this one out. :) Thanks!
   
   Reason for tests: I'd like to see the change _in action_, so to speak.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org