You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2016/04/12 11:00:35 UTC

[jira] [Commented] (OAK-3840) Clean up the FileStore constructor

    [ https://issues.apache.org/jira/browse/OAK-3840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236877#comment-15236877 ] 

Michael Dürig commented on OAK-3840:
------------------------------------

+1, I think this is a big step forward enabling a deeper refactoring by removing a lot of clutter. 

> Clean up the FileStore constructor
> ----------------------------------
>
>                 Key: OAK-3840
>                 URL: https://issues.apache.org/jira/browse/OAK-3840
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: segmentmk
>            Reporter: Michael Dürig
>            Assignee: Francesco Mari
>              Labels: technical_debt
>         Attachments: OAK-3840-01.patch
>
>
> The {{FileStore}} constructor consists of more than 150 LoC and is a mess as it depends on the order of initialisation, calls overrideable methods handles different concerns (read only vs. read / write) etc. 
> We should up with a cleaner way of instantiating a file store.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)