You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/09/03 06:05:27 UTC
[GitHub] [hive] kasakrisz opened a new pull request #1464: [WIP]HIVE-23406: SharedWorkOptimizer should check nullSortOrders when comparing ReduceSink operators
kasakrisz opened a new pull request #1464:
URL: https://github.com/apache/hive/pull/1464
### What changes were proposed in this pull request?
SharedWorkOptimizer compares ReduceSinkOperators by comparing the operators' configs in ReduceSinkDesc but it doesn't check null sort order.
### Why are the changes needed?
ReduceSinkOperators are considered to be equal if both operators has a ReduceSinkDesc object holding the same configuration. However null sort order was not checked during similarity check.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Run SharedWorkOptimizer q tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz merged pull request #1464: [WIP]HIVE-23406: SharedWorkOptimizer should check nullSortOrders when comparing ReduceSink operators
Posted by GitBox <gi...@apache.org>.
kasakrisz merged pull request #1464:
URL: https://github.com/apache/hive/pull/1464
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org