You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Alex Behm (Code Review)" <ge...@cloudera.org> on 2016/09/02 13:36:33 UTC
[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test nested types.py
Alex Behm has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4302
Change subject: IMPALA-3491: Use unique database fixture in test_nested_types.py
......................................................................
IMPALA-3491: Use unique database fixture in test_nested_types.py
Testing: Ran the tests locally in a loop. Did a core/debug/hdfs
private build.
Change-Id: I0c56df0c6a5f771222dedb69353f8bebe01d5a90
---
M testdata/workloads/functional-query/queries/QueryTest/max-nesting-depth.test
M tests/query_test/test_nested_types.py
2 files changed, 88 insertions(+), 131 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/4302/1
--
To view, visit http://gerrit.cloudera.org:8080/4302
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c56df0c6a5f771222dedb69353f8bebe01d5a90
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test nested types.py
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-3491: Use unique database fixture in test_nested_types.py
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4302/1/tests/query_test/test_nested_types.py
File tests/query_test/test_nested_types.py:
PS1, Line 22: import random
> Double check me, but I don't believe this import is needed.
You are correct. I cleaned up the imports.
PS1, Line 82: TESTFILE_DIR = os.environ['IMPALA_HOME'] + "/testdata/parquet_nested_types_encodings"
> Use os.path.join to form this directory path.
Done
--
To view, visit http://gerrit.cloudera.org:8080/4302
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c56df0c6a5f771222dedb69353f8bebe01d5a90
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test nested types.py
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Hello Michael Brown,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4302
to look at the new patch set (#2).
Change subject: IMPALA-3491: Use unique database fixture in test_nested_types.py
......................................................................
IMPALA-3491: Use unique database fixture in test_nested_types.py
Testing: Ran the tests locally in a loop. Did a core/debug/hdfs
private build.
Change-Id: I0c56df0c6a5f771222dedb69353f8bebe01d5a90
---
M testdata/workloads/functional-query/queries/QueryTest/max-nesting-depth.test
M tests/query_test/test_nested_types.py
2 files changed, 91 insertions(+), 135 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/4302/2
--
To view, visit http://gerrit.cloudera.org:8080/4302
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0c56df0c6a5f771222dedb69353f8bebe01d5a90
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test nested types.py
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-3491: Use unique database fixture in test_nested_types.py
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Seems straightforward. I found two lines that aren't yours but could use some attention.
http://gerrit.cloudera.org:8080/#/c/4302/1/tests/query_test/test_nested_types.py
File tests/query_test/test_nested_types.py:
PS1, Line 22: import random
Double check me, but I don't believe this import is needed.
PS1, Line 82: TESTFILE_DIR = os.environ['IMPALA_HOME'] + "/testdata/parquet_nested_types_encodings"
Use os.path.join to form this directory path.
--
To view, visit http://gerrit.cloudera.org:8080/4302
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c56df0c6a5f771222dedb69353f8bebe01d5a90
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test nested types.py
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-3491: Use unique database fixture in test_nested_types.py
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4302
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c56df0c6a5f771222dedb69353f8bebe01d5a90
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test nested types.py
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3491: Use unique database fixture in test_nested_types.py
......................................................................
IMPALA-3491: Use unique database fixture in test_nested_types.py
Testing: Ran the tests locally in a loop. Did a core/debug/hdfs
private build.
Change-Id: I0c56df0c6a5f771222dedb69353f8bebe01d5a90
Reviewed-on: http://gerrit.cloudera.org:8080/4302
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Internal Jenkins
---
M testdata/workloads/functional-query/queries/QueryTest/max-nesting-depth.test
M tests/query_test/test_nested_types.py
2 files changed, 91 insertions(+), 135 deletions(-)
Approvals:
Internal Jenkins: Verified
Alex Behm: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/4302
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c56df0c6a5f771222dedb69353f8bebe01d5a90
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test nested types.py
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3491: Use unique database fixture in test_nested_types.py
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4302
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c56df0c6a5f771222dedb69353f8bebe01d5a90
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No