You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dpogue <gi...@git.apache.org> on 2016/10/12 17:55:19 UTC
[GitHub] cordova-lib pull request #502: CB-12002 - Add getAllowIntents() to ConfigPar...
GitHub user dpogue opened a pull request:
https://github.com/apache/cordova-lib/pull/502
CB-12002 - Add getAllowIntents() to ConfigParser
### Platforms affected
None, but I'm adding this as preparation for an iOS feature.
### What does this PR do?
Adds a convenience method to retrieve the list of `<allow-intent>` tags from config.xml, similar to the `getAllowNavigations()` and `getAccesses()` methods.
### What testing has been done on this change?
Additions to the existing spec tests.
### Checklist
- [x] Reported an issue in the JIRA database: [CB-12002](https://issues.apache.org/jira/browse/CB-12002)
- [x] Commit message follows the format
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dpogue/cordova-lib get-intents
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/502.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #502
----
commit 84f633321c94341f05dad725b90dc016b12ee44b
Author: Darryl Pogue <da...@ayogo.com>
Date: 2016-10-12T17:48:26Z
CB-12002 - Add getAllowIntents() to ConfigParser
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #502: CB-12002 - Add getAllowIntents() to ConfigPar...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/502
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #502: CB-12002 - Add getAllowIntents() to ConfigParser
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/502
## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/502?src=pr) is 80.40% (diff: 100%)
> Merging [#502](https://codecov.io/gh/apache/cordova-lib/pull/502?src=pr) into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) will not change coverage
```diff
@@ master #502 diff @@
==========================================
Files 67 67
Lines 5189 5189
Methods 836 836
Messages 0 0
Branches 1005 1005
==========================================
Hits 4172 4172
Misses 1017 1017
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [c44db3d...84f6333](https://codecov.io/gh/apache/cordova-lib/compare/c44db3d7a00779d5c7eb5ae6150847156858a4f7...84f633321c94341f05dad725b90dc016b12ee44b?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #502: CB-12002 - Add getAllowIntents() to ConfigParser
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/502
Let's try to get this in for the tool release for cordova-ios 4.3.0 release
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org