You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Jarek Cecho <ja...@apache.org> on 2013/04/22 03:57:28 UTC
Review Request: FLUME-2013 Parametrize java source and target version in the
main pom file
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10694/
-----------------------------------------------------------
Review request for Flume.
Description
-------
I've created properties sourceJavaVersion and targetJavaVersion that can user override on the command line.
This addresses bug FLUME-2013.
https://issues.apache.org/jira/browse/FLUME-2013
Diffs
-----
pom.xml 36f989d007ac8c77682a33805597743fc9d64a52
Diff: https://reviews.apache.org/r/10694/diff/
Testing
-------
I've tested target 1.6 and 1.7.
Thanks,
Jarek Cecho
Re: Review Request: FLUME-2013 Parametrize java source and target version in
the main pom file
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10694/#review19801
-----------------------------------------------------------
Ship it!
+1, tested this against JDK6 using -DsourceJavaVersion=1.7 and of course it failed (as expected). Looks good.
- Mike Percy
On April 22, 2013, 1:57 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10694/
> -----------------------------------------------------------
>
> (Updated April 22, 2013, 1:57 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> I've created properties sourceJavaVersion and targetJavaVersion that can user override on the command line.
>
>
> This addresses bug FLUME-2013.
> https://issues.apache.org/jira/browse/FLUME-2013
>
>
> Diffs
> -----
>
> pom.xml 36f989d007ac8c77682a33805597743fc9d64a52
>
> Diff: https://reviews.apache.org/r/10694/diff/
>
>
> Testing
> -------
>
> I've tested target 1.6 and 1.7.
>
>
> Thanks,
>
> Jarek Cecho
>
>