[GitHub] [beam] aaltay commented on a diff in pull request #25210: Ignore flags for beam_sql magic

["aaltay (via GitHub)" <gi...@apache.org>]

aaltay commented on code in PR #25210:
URL: https://github.com/apache/beam/pull/25210#discussion_r1091020278


##########
sdks/python/apache_beam/runners/interactive/sql/utils.py:
##########
@@ -161,7 +161,8 @@ class OptionsForm:
   generate PipelineOptions to run pipelines.
   """
   def __init__(self):
-    self.options = PipelineOptions()
+    # ignore all flags

Review Comment:
   Could you add a link to a TODO bug, or an expanded comment explaining why this is needed here?



##########
sdks/python/apache_beam/runners/interactive/sql/utils.py:
##########
@@ -161,7 +161,8 @@ class OptionsForm:
   generate PipelineOptions to run pipelines.
   """
   def __init__(self):
-    self.options = PipelineOptions()
+    # ignore all flags
+    self.options = PipelineOptions(flags={})

Review Comment:
   Would this break any other use cases? How can we test for that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org