You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/25 15:15:05 UTC
[GitHub] [spark] yaooqinn opened a new pull request #28020:
[MINOR][BUILD][Unidoc] Pin the avro version in SBT
yaooqinn opened a new pull request #28020: [MINOR][BUILD][Unidoc] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
add arvo dep in SparkBuild
### Why are the changes needed?
fix sbt unidoc like https://github.com/apache/spark/pull/28017#issuecomment-603828597
```scala
[warn] Multiple main classes detected. Run 'show discoveredMainClasses' to see the list
[warn] Multiple main classes detected. Run 'show discoveredMainClasses' to see the list
[info] Main Scala API documentation to /home/jenkins/workspace/SparkPullRequestBuilder@6/target/scala-2.12/unidoc...
[info] Main Java API documentation to /home/jenkins/workspace/SparkPullRequestBuilder@6/target/javaunidoc...
[error] /home/jenkins/workspace/SparkPullRequestBuilder@6/core/src/main/scala/org/apache/spark/serializer/GenericAvroSerializer.scala:123: value createDatumWriter is not a member of org.apache.avro.generic.GenericData
[error] writerCache.getOrElseUpdate(schema, GenericData.get.createDatumWriter(schema))
[error] ^
[info] No documentation generated with unsuccessful compiler run
[error] one error found
```
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
pass jenkins
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28020: [SPARK-31258][BUILD]
Pin the avro version in SBT
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28020: [SPARK-31258][BUILD] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-604770772
Let me don't port it back considering the complexity vs the gain for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28020: [MINOR][BUILD][Unidoc]
Pin the avro version in SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28020: [MINOR][BUILD][Unidoc] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-603899734
**[Test build #120361 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120361/testReport)** for PR 28020 at commit [`1c0ead9`](https://github.com/apache/spark/commit/1c0ead9c811d4318c45ce9fe83d2757c83471b86).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28020:
[MINOR][BUILD][Unidoc] Pin the avro version in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28020: [MINOR][BUILD][Unidoc] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-603900653
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28020:
[MINOR][BUILD] Pin the avro version in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28020: [MINOR][BUILD] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-604019010
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28020: [SPARK-31258][BUILD]
Pin the avro version in SBT
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28020: [SPARK-31258][BUILD] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-604180663
Looks good given they many people faced this randomly in unidoc. I checked the avro version is 1.8.2 from branch-2.4 to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #28020: [MINOR][BUILD][Unidoc]
Pin the avro version in SBT
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #28020: [MINOR][BUILD][Unidoc] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-603898818
cc @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28020:
[MINOR][BUILD] Pin the avro version in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28020: [MINOR][BUILD] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-604019020
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120361/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28020: [SPARK-31258][BUILD]
Pin the avro version in SBT
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28020: [SPARK-31258][BUILD] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-604769449
Hm, I see. thanks for checking it, and reverting @dongjoon-hyun.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28020: [MINOR][BUILD] Pin the
avro version in SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28020: [MINOR][BUILD] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-604017811
**[Test build #120361 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120361/testReport)** for PR 28020 at commit [`1c0ead9`](https://github.com/apache/spark/commit/1c0ead9c811d4318c45ce9fe83d2757c83471b86).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28020: [SPARK-31258][BUILD]
Pin the avro version in SBT
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28020: [SPARK-31258][BUILD] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-604181546
Merged to master, branch-3.0, and branch-2.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28020:
[SPARK-31258][BUILD] Pin the avro version in SBT
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28020: [SPARK-31258][BUILD] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-604677810
Currently, this blocks the `branch-2.4` PR builder , too. I'll revert this first from `branch-2.4`. Please make a PR against `branch-2.4`. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on issue #28020:
[SPARK-31258][BUILD] Pin the avro version in SBT
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on issue #28020: [SPARK-31258][BUILD] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-604675195
The current situation is due to the incompatiblity between Avro 1.7 and 1.8.
Since `Maven` works correct, this seems to be caused by the outdated `sbt-avro` plugin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28020: [MINOR][BUILD] Pin
the avro version in SBT
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28020: [MINOR][BUILD] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-604141227
Also, let's file a JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28020:
[SPARK-31258][BUILD] Pin the avro version in SBT
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28020: [SPARK-31258][BUILD] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-604675195
The current situation is due to the incompatiblity between Avro 1.7 and 1.8.
This might be the outdated `sbt-avro` plugin issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28020: [MINOR][BUILD]
Pin the avro version in SBT
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28020: [MINOR][BUILD] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-603899734
**[Test build #120361 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120361/testReport)** for PR 28020 at commit [`1c0ead9`](https://github.com/apache/spark/commit/1c0ead9c811d4318c45ce9fe83d2757c83471b86).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28020: [MINOR][BUILD] Pin
the avro version in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28020: [MINOR][BUILD] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-604019020
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120361/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28020:
[MINOR][BUILD][Unidoc] Pin the avro version in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28020: [MINOR][BUILD][Unidoc] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-603900667
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25071/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28020:
[SPARK-31258][BUILD] Pin the avro version in SBT
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28020: [SPARK-31258][BUILD] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-604663331
Hi, @HyukjinKwon and @yaooqinn .
This seems to break `branch-2.4` SBT build at `org.apache.spark.streaming.flume.sink.SparkSinkSuite`.
- https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-branch-2.4-test-sbt-hadoop-2.6/
- https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-branch-2.4-test-sbt-hadoop-2.7/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28020: [MINOR][BUILD] Pin
the avro version in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28020: [MINOR][BUILD] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-604019010
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #28020: [SPARK-31258][BUILD]
Pin the avro version in SBT
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #28020: [SPARK-31258][BUILD] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-604178225
@dongjoon-hyun @HyukjinKwon, thanks. I have filed the Jira and update sbt-dependencyTree
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28020:
[MINOR][BUILD][Unidoc] Pin the avro version in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28020: [MINOR][BUILD][Unidoc] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-603900667
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25071/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28020:
[MINOR][BUILD][Unidoc] Pin the avro version in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28020: [MINOR][BUILD][Unidoc] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020#issuecomment-603900653
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #28020:
[SPARK-31258][BUILD] Pin the avro version in SBT
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #28020: [SPARK-31258][BUILD] Pin the avro version in SBT
URL: https://github.com/apache/spark/pull/28020
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org