[jira] [Comment Edited] (PHOENIX-1079) Fix HTable resource leaks

["Anoop Sam John (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14057301#comment-14057301 ] 

Anoop Sam John edited comment on PHOENIX-1079 at 7/10/14 9:24 AM:
------------------------------------------------------------------

We get HTable object by
HBaseFactoryProvider.getHTableFactory().getTable(tableName, connection, getExecutor());
So we pass the connection and pool and close() is not having much role. So there wont be any leak as such even if we don't close.
Still it is good to do that as that is the best coding practice. 
+1
I can commit this James.


was (Author: anoop.hbase):
We get HTable object by
HBaseFactoryProvider.getHTableFactory().getTable(tableName, connection, getExecutor());
So we pass the connection and pool and close() is not having mich role.  So there wont be any leak as such even if we dont close.
Still it is good to do that as that is the best coding practise.  
+1
I can commit this James.

> Fix HTable resource leaks
> -------------------------
>
>                 Key: PHOENIX-1079
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1079
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>             Fix For: 3.0.0, 4.0.0, 5.0.0
>
>         Attachments: master.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)