[jira] [Resolved] (OAK-7232) MountPermissionProvider.load can return null

["angela (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela resolved OAK-7232.
-------------------------
       Resolution: Fixed
    Fix Version/s: 1.10
                   1.9.0

Committed revision 1822955.

[~stillalex], fyi

> MountPermissionProvider.load can return null
> --------------------------------------------
>
>                 Key: OAK-7232
>                 URL: https://issues.apache.org/jira/browse/OAK-7232
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, security
>            Reporter: angela
>            Assignee: angela
>            Priority: Major
>             Fix For: 1.9.0, 1.10
>
>         Attachments: OAK-7232.patch
>
>
> while adding missing annotations to {{MountPermissionProvider}} i noticed that the load method is actually defined as follows on the interface:
> {code}
> /**
>      * Loads the permission entries for the given principal and path. if the given {@code entries} is {@code null}, it
>      * will be created automatically if needed. If a {@code entries} is given, it will reuse it and the same object is
>      * returned. If no entries can be found for the given principal or path, {@code null} is returned.
>      *
>      * @param entries the permission entries or {@code null}
>      * @param principalName name of the principal
>      * @param path access controlled path.
>      * @return the given {@code entries}, a new collection or {@code null}
>      */
>     @CheckForNull
>     Collection<PermissionEntry> load(@Nullable Collection<PermissionEntry> entries, @Nonnull String principalName, @Nonnull String path);
> {code}
> IMO this means that the implementation in {{MountPermissionProvider}} could return {{null}} instead of creating an empty set.
> [~stillalex], wdyt? (proposed patch including the missing annoatations attached).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)