You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by se...@apache.org on 2016/09/19 09:15:02 UTC
cxf git commit: Fixing SSE module checkstyle issues
Repository: cxf
Updated Branches:
refs/heads/master bd8aff665 -> c978ca027
Fixing SSE module checkstyle issues
Project: http://git-wip-us.apache.org/repos/asf/cxf/repo
Commit: http://git-wip-us.apache.org/repos/asf/cxf/commit/c978ca02
Tree: http://git-wip-us.apache.org/repos/asf/cxf/tree/c978ca02
Diff: http://git-wip-us.apache.org/repos/asf/cxf/diff/c978ca02
Branch: refs/heads/master
Commit: c978ca0274c06abd6ebf67adf2a839c4624b4906
Parents: bd8aff6
Author: Sergey Beryozkin <sb...@gmail.com>
Authored: Mon Sep 19 10:14:44 2016 +0100
Committer: Sergey Beryozkin <sb...@gmail.com>
Committed: Mon Sep 19 10:14:44 2016 +0100
----------------------------------------------------------------------
.../cxf/jaxrs/sse/OutboundSseEventImpl.java | 35 ++++++++++----------
.../SseAtmosphereEventOutputImpl.java | 2 +-
.../cdi/SseTransportCustomizationExtension.java | 2 +-
3 files changed, 20 insertions(+), 19 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cxf/blob/c978ca02/rt/rs/sse/src/main/java/org/apache/cxf/jaxrs/sse/OutboundSseEventImpl.java
----------------------------------------------------------------------
diff --git a/rt/rs/sse/src/main/java/org/apache/cxf/jaxrs/sse/OutboundSseEventImpl.java b/rt/rs/sse/src/main/java/org/apache/cxf/jaxrs/sse/OutboundSseEventImpl.java
index f852637..edff945 100644
--- a/rt/rs/sse/src/main/java/org/apache/cxf/jaxrs/sse/OutboundSseEventImpl.java
+++ b/rt/rs/sse/src/main/java/org/apache/cxf/jaxrs/sse/OutboundSseEventImpl.java
@@ -45,14 +45,14 @@ public class OutboundSseEventImpl implements OutboundSseEvent {
private Object data;
@Override
- public Builder id(String id) {
- this.id = id;
+ public Builder id(String newId) {
+ this.id = newId;
return this;
}
@Override
- public Builder name(String name) {
- this.name = name;
+ public Builder name(String newName) {
+ this.name = newName;
return this;
}
@@ -63,36 +63,36 @@ public class OutboundSseEventImpl implements OutboundSseEvent {
}
@Override
- public Builder mediaType(MediaType mediaType) {
- this.mediaType = mediaType;
+ public Builder mediaType(MediaType newMediaType) {
+ this.mediaType = newMediaType;
return this;
}
@Override
- public Builder comment(String comment) {
- this.comment = comment;
+ public Builder comment(String newComment) {
+ this.comment = newComment;
return this;
}
@Override
@SuppressWarnings("rawtypes")
- public Builder data(Class type, Object data) {
- this.type = type;
- this.data= data;
+ public Builder data(Class newType, Object newData) {
+ this.type = newType;
+ this.data = newData;
return this;
}
@Override
@SuppressWarnings("rawtypes")
- public Builder data(GenericType type, Object data) {
- this.genericType = type.getType();
- this.data= data;
+ public Builder data(GenericType newType, Object newData) {
+ this.genericType = newType.getType();
+ this.data = newData;
return this;
}
@Override
- public Builder data(Object data) {
- this.data = data;
+ public Builder data(Object newData) {
+ this.data = newData;
return this;
}
@@ -111,7 +111,7 @@ public class OutboundSseEventImpl implements OutboundSseEvent {
}
}
-
+ //CHECKSTYLE:OFF
OutboundSseEventImpl(String id, String name, String comment, long reconnectDelay,
Class<?> type, Type genericType, MediaType mediaType, Object data) {
this.id = id;
@@ -123,6 +123,7 @@ public class OutboundSseEventImpl implements OutboundSseEvent {
this.mediaType = mediaType;
this.data = data;
}
+ //CHECKSTYLE:ON
@Override
public String getId() {
http://git-wip-us.apache.org/repos/asf/cxf/blob/c978ca02/rt/rs/sse/src/main/java/org/apache/cxf/jaxrs/sse/atmosphere/SseAtmosphereEventOutputImpl.java
----------------------------------------------------------------------
diff --git a/rt/rs/sse/src/main/java/org/apache/cxf/jaxrs/sse/atmosphere/SseAtmosphereEventOutputImpl.java b/rt/rs/sse/src/main/java/org/apache/cxf/jaxrs/sse/atmosphere/SseAtmosphereEventOutputImpl.java
index cbf1a26..3896ec6 100644
--- a/rt/rs/sse/src/main/java/org/apache/cxf/jaxrs/sse/atmosphere/SseAtmosphereEventOutputImpl.java
+++ b/rt/rs/sse/src/main/java/org/apache/cxf/jaxrs/sse/atmosphere/SseAtmosphereEventOutputImpl.java
@@ -41,7 +41,7 @@ public class SseAtmosphereEventOutputImpl implements SseEventOutput {
private final AtmosphereResource resource;
private final MessageBodyWriter<OutboundSseEvent> writer;
- private volatile boolean closed = false;
+ private volatile boolean closed;
public SseAtmosphereEventOutputImpl(final MessageBodyWriter<OutboundSseEvent> writer,
final AtmosphereResource resource) {
http://git-wip-us.apache.org/repos/asf/cxf/blob/c978ca02/rt/rs/sse/src/main/java/org/apache/cxf/jaxrs/sse/cdi/SseTransportCustomizationExtension.java
----------------------------------------------------------------------
diff --git a/rt/rs/sse/src/main/java/org/apache/cxf/jaxrs/sse/cdi/SseTransportCustomizationExtension.java b/rt/rs/sse/src/main/java/org/apache/cxf/jaxrs/sse/cdi/SseTransportCustomizationExtension.java
index f4ea862..68af13c 100644
--- a/rt/rs/sse/src/main/java/org/apache/cxf/jaxrs/sse/cdi/SseTransportCustomizationExtension.java
+++ b/rt/rs/sse/src/main/java/org/apache/cxf/jaxrs/sse/cdi/SseTransportCustomizationExtension.java
@@ -22,7 +22,7 @@ import org.apache.cxf.cdi.extension.JAXRSServerFactoryCustomizationExtension;
import org.apache.cxf.jaxrs.JAXRSServerFactoryBean;
import org.apache.cxf.transport.sse.SseHttpTransportFactory;
-public class SseTransportCustomizationExtension implements JAXRSServerFactoryCustomizationExtension{
+public class SseTransportCustomizationExtension implements JAXRSServerFactoryCustomizationExtension {
@Override
public void customize(final JAXRSServerFactoryBean bean) {
bean.setTransportId(SseHttpTransportFactory.TRANSPORT_ID);