You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/16 16:00:36 UTC

[GitHub] [cordova-plugin-camera] PegasusAwesome opened a new issue #609: Problem with NSPhotoLibraryUsageDescription when source is GIT

PegasusAwesome opened a new issue #609:
URL: https://github.com/apache/cordova-plugin-camera/issues/609


   # Bug Report
   First of all: thanks for the wonderfull plugin :)
   
   ## Problem
   NSPhotoLibraryUsageDescription is not included in Info.plist
   
   ### What is expected to happen?
   NSPhotoLibraryUsageDescription should be included in Info.plist
   
   ### What does actually happen?
   NSPhotoLibraryUsageDescription is not included after build
   
   
   ## Information
   The problem happens when I define the plugin as such:
       <plugin name="cordova-plugin-camera" spec="https://github.com/apache/cordova-plugin-camera" source="git">
          <param name="CAMERA_USAGE_DESCRIPTION" value="We need access to scan qr codes and to show the buildingmanager pictures of the problem." />
          <param name="PHOTOLIBRARY_USAGE_DESCRIPTION" value="We need access to scan qr codes and to show the buildingmanager pictures of the problem." />
       </plugin>
   
   The problem does NOT happen when I define the plugin as this:
   <plugin name="cordova-plugin-camera" source="npm" spec="=4.1.0">
          <param name="CAMERA_USAGE_DESCRIPTION" value="We need access to scan qr codes and to show the buildingmanager pictures of the problem." />
          <param name="PHOTOLIBRARY_USAGE_DESCRIPTION" value="We need access to scan qr codes and to show the buildingmanager pictures of the problem." />
       </plugin>
   
   I've tried adding the following to the config.xml file, to prevent the problem:
           <config-file parent="NSPhotoLibraryUsageDescription" platform="ios" target="*-Info.plist">
               <string>We need access to scan qr codes and to show the buildingmanager pictures of the problem.</string>
           </config-file>
   And also:
           <edit-config target="NSPhotoLibraryUsageDescription" file="*-Info.plist" mode="merge">
               <string>We need access to scan qr codes and to show the buildingmanager pictures of the problem.</string>
           </edit-config>
   
   But both those config entries do not resolve the problem.
   
   Ps.: I need the 4.2.0 version, because of the fixes for video.
   
   ### Command or Code
   The problem occurs as soon as I place this string in the config.xml:
       <plugin name="cordova-plugin-camera" spec="https://github.com/apache/cordova-plugin-camera" source="git">
          <param name="CAMERA_USAGE_DESCRIPTION" value="We need access to scan qr codes and to show the buildingmanager pictures of the problem." />
          <param name="PHOTOLIBRARY_USAGE_DESCRIPTION" value="We need access to scan qr codes and to show the buildingmanager pictures of the problem." />
       </plugin>
   
   
   ### Environment, Platform, Device
   Phonegap build => upload to iOS
   
   ### Version information
   Phonegap CLI
   cordova-plugin-camera from git
   iOS
   
   
   ## Checklist
   
   - [X ] I searched for existing GitHub issues
   - [ X] I updated all Cordova tooling to most recent version
   - [ X] I included all the necessary information above
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-camera] PegasusAwesome edited a comment on issue #609: Problem with NSPhotoLibraryUsageDescription when source is GIT

Posted by GitBox <gi...@apache.org>.
PegasusAwesome edited a comment on issue #609:
URL: https://github.com/apache/cordova-plugin-camera/issues/609#issuecomment-648686333


   Hiya,
   
   > the plugin doesn't add usage descriptions, you have to add them using `edit-config` tags in `config.xml`
   > 
   > ```
   > <edit-config target="NSPhotoLibraryUsageDescription" file="*-Info.plist" mode="merge">
   >     <string>need photo library access to get pictures from there</string>
   > </edit-config>
   > ```
   
   As you can read in my report, I've literally tried doing exactly that. 
   And when I use one version of the plugin that works. However, with the latest version of cordova-camera-plugin, the NSPhotoLibraryUsageDescription disappears from info.plist.
   
   So, to me it seems that this is a plugin issue. One version of the plugin: no problem, other version of the plugin: there is a problem.  The plugin version is iterally the only difference I make between my two test config.xmls.
   
   Of course, if this should be reported to the cordova cli repo, I'd be happy to do so, just seems a plugin problem. 
   
   Best,
   Marcel


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-camera] PegasusAwesome edited a comment on issue #609: Problem with NSPhotoLibraryUsageDescription when source is GIT

Posted by GitBox <gi...@apache.org>.
PegasusAwesome edited a comment on issue #609:
URL: https://github.com/apache/cordova-plugin-camera/issues/609#issuecomment-648702787


   Ok, so the fact that the only difference between my two config.xml files is the plugin version, doesn't indicate that this is a plugin problem.
   Apologies if this sounds a bit bitter, this whole problem just baffles me.
   
   Anyways, thanks for looking into this and have a nice day.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-camera] jcesarmobile commented on issue #609: Problem with NSPhotoLibraryUsageDescription when source is GIT

Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on issue #609:
URL: https://github.com/apache/cordova-plugin-camera/issues/609#issuecomment-646624092


   the plugin doesn't add usage descriptions, you have to add them using `edit-config` tags in `config.xml`
   ```
   <edit-config target="NSPhotoLibraryUsageDescription" file="*-Info.plist" mode="merge">
       <string>need photo library access to get pictures from there</string>
   </edit-config>
   ``` 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-camera] jcesarmobile commented on issue #609: Problem with NSPhotoLibraryUsageDescription when source is GIT

Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on issue #609:
URL: https://github.com/apache/cordova-plugin-camera/issues/609#issuecomment-648707963


   Just noticed you use phonegap build, as far as I remember they use a slightly different syntax for the edit-config and config-file entries, that could be the problem too.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-camera] PegasusAwesome edited a comment on issue #609: Problem with NSPhotoLibraryUsageDescription when source is GIT

Posted by GitBox <gi...@apache.org>.
PegasusAwesome edited a comment on issue #609:
URL: https://github.com/apache/cordova-plugin-camera/issues/609#issuecomment-648702787


   Ok, so the fact that the only difference between my two config.xml files is the plugin version, doesn't indicate that this is a plugin problem.
   Apologies if this sounds a bit bitter, this whole problem just baffles me.
   
   Thanks for looking into this and have a nice day.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-camera] PegasusAwesome commented on issue #609: Problem with NSPhotoLibraryUsageDescription when source is GIT

Posted by GitBox <gi...@apache.org>.
PegasusAwesome commented on issue #609:
URL: https://github.com/apache/cordova-plugin-camera/issues/609#issuecomment-648710750


   still weird though that it would work with one version and not the other 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-camera] PegasusAwesome commented on issue #609: Problem with NSPhotoLibraryUsageDescription when source is GIT

Posted by GitBox <gi...@apache.org>.
PegasusAwesome commented on issue #609:
URL: https://github.com/apache/cordova-plugin-camera/issues/609#issuecomment-648686333


   Hiya,
   
   > the plugin doesn't add usage descriptions, you have to add them using `edit-config` tags in `config.xml`
   > 
   > ```
   > <edit-config target="NSPhotoLibraryUsageDescription" file="*-Info.plist" mode="merge">
   >     <string>need photo library access to get pictures from there</string>
   > </edit-config>
   > ```
   
   As you can read in my report, I've literally tried doing exactly that. 
   And when I use one version of the plugin that works. However, with the latest version of cordova-camera-plugin, the NSPhotoLibraryUsageDescription disappears from info.plist.
   
   So, to me it seems that this is a plugin issue. One version of the plugin: no problem, other version of the plugin: there is a problem. 
   
   Of course, if this should be reported to the cordova cli repo, I'd be happy to do so, just seems a plugin problem. 
   
   Best,
   Marcel


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-camera] PegasusAwesome edited a comment on issue #609: Problem with NSPhotoLibraryUsageDescription when source is GIT

Posted by GitBox <gi...@apache.org>.
PegasusAwesome edited a comment on issue #609:
URL: https://github.com/apache/cordova-plugin-camera/issues/609#issuecomment-648686333


   Hiya,
   
   > the plugin doesn't add usage descriptions, you have to add them using `edit-config` tags in `config.xml`
   > 
   > ```
   > <edit-config target="NSPhotoLibraryUsageDescription" file="*-Info.plist" mode="merge">
   >     <string>need photo library access to get pictures from there</string>
   > </edit-config>
   > ```
   
   As you can read in my report, I've literally tried doing exactly that. 
   And when I use one version of the plugin that works. However, with the latest version of cordova-camera-plugin, the NSPhotoLibraryUsageDescription disappears from info.plist.
   
   So, to me it seems that this is a plugin issue. One version of the plugin: no problem, other version of the plugin: there is a problem.  The plugin version is iterally the only difference I make between my two test config.xmls.
   As I stated in the report, this version works:
   `<plugin name="cordova-plugin-camera" source="npm" spec="=4.1.0">`
   
   And this version causes problems:
   `<plugin name="cordova-plugin-camera" spec="https://github.com/apache/cordova-plugin-camera" source="git">`
   
   Of course, if this should be reported to the cordova cli repo, I'd be happy to do so, just seems a plugin problem. 
   
   Best,
   Marcel


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-camera] PegasusAwesome commented on issue #609: Problem with NSPhotoLibraryUsageDescription when source is GIT

Posted by GitBox <gi...@apache.org>.
PegasusAwesome commented on issue #609:
URL: https://github.com/apache/cordova-plugin-camera/issues/609#issuecomment-648702787


   Ok, so the fact that the only difference between my two config.xml files is the plugin version, doesn't indicate that this is a plugin problem.
   
   Thanks and have a nice day.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-camera] PegasusAwesome edited a comment on issue #609: Problem with NSPhotoLibraryUsageDescription when source is GIT

Posted by GitBox <gi...@apache.org>.
PegasusAwesome edited a comment on issue #609:
URL: https://github.com/apache/cordova-plugin-camera/issues/609#issuecomment-648686333


   Hiya,
   
   > the plugin doesn't add usage descriptions, you have to add them using `edit-config` tags in `config.xml`
   > 
   > ```
   > <edit-config target="NSPhotoLibraryUsageDescription" file="*-Info.plist" mode="merge">
   >     <string>need photo library access to get pictures from there</string>
   > </edit-config>
   > ```
   
   As you can read in my report, I've literally tried doing exactly that. 
   And when I use one version of the plugin that works. However, with the latest version of cordova-camera-plugin, the NSPhotoLibraryUsageDescription disappears from info.plist.
   
   So, to me it seems that this is a plugin issue. One version of the plugin: no problem, other version of the plugin: there is a problem.  The plugin version is iterally the only difference I make between my two test config.xmls.
   As I stated in the report, this version works:
   <plugin name="cordova-plugin-camera" source="npm" spec="=4.1.0">
   
   And this version causes problems:
   <plugin name="cordova-plugin-camera" spec="https://github.com/apache/cordova-plugin-camera" source="git">
   
   Of course, if this should be reported to the cordova cli repo, I'd be happy to do so, just seems a plugin problem. 
   
   Best,
   Marcel


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-camera] jcesarmobile closed issue #609: Problem with NSPhotoLibraryUsageDescription when source is GIT

Posted by GitBox <gi...@apache.org>.
jcesarmobile closed issue #609:
URL: https://github.com/apache/cordova-plugin-camera/issues/609


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-camera] PegasusAwesome commented on issue #609: Problem with NSPhotoLibraryUsageDescription when source is GIT

Posted by GitBox <gi...@apache.org>.
PegasusAwesome commented on issue #609:
URL: https://github.com/apache/cordova-plugin-camera/issues/609#issuecomment-646273079


   Just tried all possible combinations: without params, with params, without edit-config, with params. Nothing works.
   The camera usage string can be found in the info.plist, but the photolibrary usage string is never in the info plist.
   Well, unless I use the older npm version...
   Anybody got any idea or workaround?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-camera] jcesarmobile commented on issue #609: Problem with NSPhotoLibraryUsageDescription when source is GIT

Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on issue #609:
URL: https://github.com/apache/cordova-plugin-camera/issues/609#issuecomment-648701293


   The thing that adds the NSPhotoLibraryUsageDescription is the CLI, not the plugin, so it’s imposible that this is a plugin issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-camera] PegasusAwesome commented on issue #609: Problem with NSPhotoLibraryUsageDescription when source is GIT

Posted by GitBox <gi...@apache.org>.
PegasusAwesome commented on issue #609:
URL: https://github.com/apache/cordova-plugin-camera/issues/609#issuecomment-648708784


   Hey, thanks, Im gonna try to google that ;)
   If you'd happen to have a url towards that syntax, Id be very grateful, if not, no worries, google-fu re-activated ;)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-camera] jcesarmobile commented on issue #609: Problem with NSPhotoLibraryUsageDescription when source is GIT

Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on issue #609:
URL: https://github.com/apache/cordova-plugin-camera/issues/609#issuecomment-646624723


   if edit-config is not working fine, then you should report it in cordova-cli repo, but it's not a plugin issue, closing


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org