[GitHub] [netbeans] jlahoda commented on a change in pull request #2107: Pack200 remove from nb installer

[GitBox <gi...@apache.org>]

jlahoda commented on a change in pull request #2107:
URL: https://github.com/apache/netbeans/pull/2107#discussion_r416343953



##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/MakeNBM.java
##########
@@ -334,14 +334,14 @@ public void setProductDir( File dir ) {
     public void setFile(File file) {
         this.file = file;
     }
-
-    public void setUsePack200(boolean usePack200) {
+    //Commented below code, as pack200 is not supported from jdk 14 onwards

Review comment:
       I guess the methods (and so their attributes in the build.xml) should stay here, for compatibility. They, of course, won't do anything.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists