[jira] [Updated] (HADOOP-13686) Adding additional unit test for Trash (I)

["Weiwei Yang (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-13686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Weiwei Yang updated HADOOP-13686:
---------------------------------
    Attachment: HADOOP-13686.01.patch

Added following tests

# {{testCheckpointInterval}} this test sets multiple values (legal and illegal) to *fs.trash.checkpoint.interval* and verify the values are set in emptier as expected.
# {{testTrashPermission}} this test verifies when files moved to trash, file permission is reserved. And user is able to remove their own trash directory.
# {{testMoveEmptyDirToTrash}} this test user is able to move an empty directory to trash.
# {{testTrashRestarts}} this tests simulates a restart of the parent process (NN), verifies *fs.trash.interval* is honoured during restart.

Some more things

bq. 3. test fs.trash.interval with invalid values such as 0 or negative

This is already covered so it's not in this patch. {{TestTrash#trashShell}} tested setting value to 0. {{TestStateTransitionFailure}} tested setting a negative value. Namenode will not be started with error "Cannot start trash emptier with negative interval. Set fs.trash.interval to a positive value". 

And this patch fixed an issue that setting a negative value to fs.trash.checkpoint.interval is not handled in {{TrashPolicyDefault}}.


> Adding additional unit test for Trash (I)
> -----------------------------------------
>
>                 Key: HADOOP-13686
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13686
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Xiaoyu Yao
>            Assignee: Weiwei Yang
>         Attachments: HADOOP-13686.01.patch
>
>
> This ticket is opened to track adding the forllowing unit test in hadoop-common. 
> #test users can delete their own trash directory
> #test users can delete an empty directory and the directory is moved to trash
> #test fs.trash.interval with invalid values such as 0 or negative



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org