You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/28 19:08:20 UTC

[GitHub] [beam] tvalentyn commented on a change in pull request #11548: [BEAM-9136] Improve docker-pull-licenses tag.

tvalentyn commented on a change in pull request #11548:
URL: https://github.com/apache/beam/pull/11548#discussion_r416855737



##########
File path: sdks/java/container/build.gradle
##########
@@ -101,16 +84,44 @@ docker {
                   project.rootProject["docker-tag"] : project.sdk_version)
   dockerfile project.file("./${dockerfileName}")
   files "./build/"
+  buildArgs(['pull_licenses': !project.rootProject.hasProperty(["no-licenses"])])

Review comment:
       Sounds good. Sorry if this was covered in the discussion that I didn't read, but why would we want to check urls but not pull? Feel free to point me to the discussion.
   
   Naming suggestion:
   licenses-in-docker-images=add
   licenses-in-docker-images=skip
   licenses-in-docker-images=check_urls




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org