You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mbalassi <gi...@git.apache.org> on 2015/06/15 15:25:50 UTC
[GitHub] flink pull request: [build] Merge transitive notice files to shade...
GitHub user mbalassi opened a pull request:
https://github.com/apache/flink/pull/837
[build] Merge transitive notice files to shaded notices
This is a proposed solution for adding the transitive notice information to our shaded jars. The notice files are simply merged, and are not as readable as the hand edited ones, but each piece of notice information is clearly linkable to a single dependency.
This is the solution that I have seen being used in similar cases, e.g. [here](https://github.com/apache/spark/blob/16fc49617e1dfcbe9122b224f7f63b7bfddb36ce/external/kafka-assembly/pom.xml).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbalassi/flink notices
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/837.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #837
----
commit 96d302e52ac27feb4cfdca75949e962ed6145791
Author: mbalassi <mb...@apache.org>
Date: 2015-06-15T13:15:49Z
[build] Merge transitive notice files to shaded notices
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [build] Merge transitive notice files to shade...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/837
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [build] Merge transitive notice files to shade...
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/837#issuecomment-112432774
Found the bug, was a trivial one on my side. Now the produced NOTICE looks the following for e.g. flink-shaded-hadoop. [1]
It would be a bit nicer if we could clearly state the NOTICE belongs to a Flink jar, but that is not ensured currently. I have looked at the source code of the transformer we are using and other Maven projects with shading and I did not find approaches different from the current one, so I hope that this solution is sufficient.
[1] http://pastebin.com/xB638R28
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [build] Merge transitive notice files to shade...
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/837#issuecomment-112131002
A quick call with @rmetzger enlightened me on the possible cause, maybe I managed to unwillingly disable another transformer. Debugging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [build] Merge transitive notice files to shade...
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/837#issuecomment-112093450
This seems to break the hadoop-2 builds currently somehow. Does anyone have an idea why it happens? :) (Same errors occured in the apache and my travis runs too.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---